ci: add Lint check on commits (zeromicro#1086)

* ci: add Lint check on commits * ci: fix Lint script error * test: fix go vet errors * test: fix go vet errors, remove gofumpt to check go vet * test: fix go vet errors, try gofumpt * test: fix go vet errors, try gofumpt, round 1 * test: fix go vet errors, try gofumpt, round 2 * ci: fix Lint errors
bensonfx · Sep 23, 2021 · 8403ed1 · 8403ed1
1 parent d87d203
commit 8403ed1
Show file tree

Hide file tree

Showing 12 changed files with 41 additions and 16 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -25,6 +25,12 @@ jobs:
       run: |
         go get -v -t -d ./...
 
+    - name: Lint
+      run: |
+        go vet -stdmethods=false $(go list ./...)
+        go install mvdan.cc/gofumpt@latest
+        test -z "$(gofumpt -s -l -extra .)"
+
     - name: Test
       run: go test -race -coverprofile=coverage.txt -covermode=atomic ./...
 

diff --git a/core/discov/internal/statewatcher_mock.go b/core/discov/internal/statewatcher_mock.go
diff --git a/core/discov/internal/updatelistener_mock.go b/core/discov/internal/updatelistener_mock.go
diff --git a/core/fs/files.go b/core/fs/files.go
@@ -1,3 +1,4 @@
+//go:build linux || darwin
 // +build linux darwin
 
 package fs

diff --git a/core/proc/shutdown.go b/core/proc/shutdown.go
@@ -1,3 +1,4 @@
+//go:build linux || darwin
 // +build linux darwin
 
 package proc

diff --git a/core/search/tree_debug.go b/core/search/tree_debug.go
@@ -1,3 +1,4 @@
+//go:build debug
 // +build debug
 
 package search

diff --git a/core/stat/alert.go b/core/stat/alert.go
@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 package stat

diff --git a/core/stat/alert_test.go b/core/stat/alert_test.go
@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 package stat

diff --git a/core/stores/mongo/internal/collection_mock.go b/core/stores/mongo/internal/collection_mock.go
diff --git a/core/stores/mongo/iter_mock.go b/core/stores/mongo/iter_mock.go
diff --git a/core/syncx/pool_test.go b/core/syncx/pool_test.go
@@ -17,10 +17,11 @@ func TestPoolGet(t *testing.T) {
 	ch := make(chan lang.PlaceholderType)
 
 	for i := 0; i < limit; i++ {
+		var fail AtomicBool
 		go func() {
 			v := stack.Get()
 			if v.(int) != 1 {
-				t.Fatal("unmatch value")
+				fail.Set(true)
 			}
 			ch <- lang.Placeholder
 		}()
@@ -30,6 +31,10 @@ func TestPoolGet(t *testing.T) {
 		case <-time.After(time.Second):
 			t.Fail()
 		}
+
+		if fail.True() {
+			t.Fatal("unmatch value")
+		}
 	}
 }
 

diff --git a/zrpc/internal/mock/deposit.pb.go b/zrpc/internal/mock/deposit.pb.go