Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Ruby 2.5 and JRuby 9.2; reactivate appraisal tests for Rails HEAD #756

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Dec 4, 2022

  • I'm unable to build either Ruby 2.5 or JRuby 9.2 locally 😞
  • Ruby 2.5 has been EOL since March 31, 2021.
  • JRuby 9.2 is no longer listed on the JRuby Downloads page.

@bensheldon bensheldon temporarily deployed to goodjob-rails-head-7n1o96x25nb December 4, 2022 20:56 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-rails-head-7n1o96x25nb December 6, 2022 15:39 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-rails-head-7n1o96x25nb December 6, 2022 15:53 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-rails-head-7n1o96x25nb December 6, 2022 16:44 Inactive
@bensheldon bensheldon changed the title Reactivate appraisal tests for Rails HEAD Remove support for Ruby 2.5 and JRuby 9.2; reactivate appraisal tests for Rails HEAD Jan 30, 2023
@bensheldon
Copy link
Owner Author

@morgoth is it ok to remove support for JRuby 9.2 (Ruby 2.5 compatibility)? I can't seem to find an updated EOL policy for JRuby 9.X.

@morgoth
Copy link
Collaborator

morgoth commented Jan 31, 2023

I'm not familiar with jRuby ecosystem, but I would say yes.
Looks like Rails doesn't run CI tests at all for jRuby.

@bensheldon bensheldon added the dependencies Pull requests that update a dependency file label Jan 31, 2023
@bensheldon bensheldon merged commit 226611e into main Jan 31, 2023
@bensheldon bensheldon deleted the rails-head branch January 31, 2023 14:15
bensheldon added a commit that referenced this pull request Jan 31, 2023
* Bump selenium-webdriver from 4.7.1 to 4.8.0 (#816)

Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.7.1 to 4.8.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.8.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump concurrent-ruby from 1.1.10 to 1.2.0 (#818)

Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) from 1.1.10 to 1.2.0.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases)
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md)
- [Commits](ruby-concurrency/concurrent-ruby@v1.1.10...v1.2.0)

---
updated-dependencies:
- dependency-name: concurrent-ruby
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump alex-page/github-project-automation-plus from 0.8.2 to 0.8.3 (#819)

Bumps [alex-page/github-project-automation-plus](https://github.com/alex-page/github-project-automation-plus) from 0.8.2 to 0.8.3.
- [Release notes](https://github.com/alex-page/github-project-automation-plus/releases)
- [Commits](alex-page/github-project-automation-plus@1f8873e...7ffb872)

---
updated-dependencies:
- dependency-name: alex-page/github-project-automation-plus
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove support for Ruby 2.5 and JRuby 9.2; reactivate appraisal tests for Rails HEAD (#756)

* Reactivate appraisal tests for Rails HEAD

* Remove Database Cleaner

* Poke Puma to ensure Rails fully bootstraps

* Use latest rubygems in all the workflow runs

* Remove Ruby 2.5 from test matrix

* Update Ruby (2.6+) and JRuby (9.3+) compatibility

* Bump rails from 6.1.7 to 6.1.7.2 (#817)

Bumps [rails](https://github.com/rails/rails) from 6.1.7 to 6.1.7.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v6.1.7...v6.1.7.2)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rubocop from 1.43.0 to 1.44.1

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.43.0 to 1.44.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.43.0...v1.44.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Disable Gemspec/DevelopmentDependencies

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Sheldon [he/him] <bensheldon@gmail.com>
@bensheldon bensheldon mentioned this pull request Feb 6, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

2 participants