-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Ruby 2.5 and JRuby 9.2; reactivate appraisal tests for Rails HEAD #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bensheldon
commented
Dec 4, 2022
•
edited
Loading
edited
- I'm unable to build either Ruby 2.5 or JRuby 9.2 locally 😞
- Ruby 2.5 has been EOL since March 31, 2021.
- JRuby 9.2 is no longer listed on the JRuby Downloads page.
8995d0b
to
c10b625
Compare
c10b625
to
8b11db1
Compare
8b11db1
to
6c86065
Compare
1edcd2a
to
9b3ff41
Compare
c6eb0fb
to
08afb67
Compare
@morgoth is it ok to remove support for JRuby 9.2 (Ruby 2.5 compatibility)? I can't seem to find an updated EOL policy for JRuby 9.X. |
08afb67
to
2762ed6
Compare
I'm not familiar with jRuby ecosystem, but I would say yes. |
bensheldon
added a commit
that referenced
this pull request
Jan 31, 2023
* Bump selenium-webdriver from 4.7.1 to 4.8.0 (#816) Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.7.1 to 4.8.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES) - [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.8.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump concurrent-ruby from 1.1.10 to 1.2.0 (#818) Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) from 1.1.10 to 1.2.0. - [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases) - [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md) - [Commits](ruby-concurrency/concurrent-ruby@v1.1.10...v1.2.0) --- updated-dependencies: - dependency-name: concurrent-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump alex-page/github-project-automation-plus from 0.8.2 to 0.8.3 (#819) Bumps [alex-page/github-project-automation-plus](https://github.com/alex-page/github-project-automation-plus) from 0.8.2 to 0.8.3. - [Release notes](https://github.com/alex-page/github-project-automation-plus/releases) - [Commits](alex-page/github-project-automation-plus@1f8873e...7ffb872) --- updated-dependencies: - dependency-name: alex-page/github-project-automation-plus dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove support for Ruby 2.5 and JRuby 9.2; reactivate appraisal tests for Rails HEAD (#756) * Reactivate appraisal tests for Rails HEAD * Remove Database Cleaner * Poke Puma to ensure Rails fully bootstraps * Use latest rubygems in all the workflow runs * Remove Ruby 2.5 from test matrix * Update Ruby (2.6+) and JRuby (9.3+) compatibility * Bump rails from 6.1.7 to 6.1.7.2 (#817) Bumps [rails](https://github.com/rails/rails) from 6.1.7 to 6.1.7.2. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v6.1.7...v6.1.7.2) --- updated-dependencies: - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump rubocop from 1.43.0 to 1.44.1 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.43.0 to 1.44.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.43.0...v1.44.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Disable Gemspec/DevelopmentDependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Sheldon [he/him] <bensheldon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.