Skip to content

Feature/fetch comments exponential retries #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/fetch comments exponential retries #153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8274f9
Added exponential backoff for FetchComments
Dec 23, 2024
b3f656e
Removed logging between retries
Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions hn/services/hybrid/hybrid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"strconv"
"sync/atomic"
"time"
"math/rand"

"github.com/bobesa/go-domain-util/domainutil"

Expand Down Expand Up @@ -138,15 +139,36 @@ func mapItem(hn *endpoints.HN) *item.Item {
}

func (s *Service) FetchComments(id int) *item.Item {
client := resty.New()
client.SetTimeout(5 * time.Second)
client.SetBaseURL("http://api.hackerwebapp.com/item/")

response, err := client.R().
SetHeader("User-Agent", app.Name+"/"+app.Version).
Get(strconv.Itoa(id))
baseTimeout := 5 * time.Second
maxRetries := 3

var response *resty.Response
var err error

for attempt := 1; attempt <= maxRetries; attempt++ {
client := resty.New()
// Increase timeout
client.SetTimeout(baseTimeout * time.Duration(attempt))
client.SetBaseURL("http://api.hackerwebapp.com/item/")


response, err = client.R().
SetHeader("User-Agent", app.Name+"/"+app.Version).
Get(strconv.Itoa(id))
if err == nil {
break // Successful request
}

// Exponential backoff with random jitter
jitter := time.Duration(rand.Intn(500)) * time.Millisecond
backoff := (1 << attempt) * time.Second
time.Sleep(backoff + jitter)
}

if err != nil {
panic(err)
// All attempts failed, log error
fmt.Printf("Failed to fetch comments after %d retires: %w", maxRetries, err)
}

sanitizedResponse := ansi.Strip(string(response.Body()))
Expand Down