temp fix for mutable actions #18
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides a temporary fix for the issue of mutable actions. It turned out that the current client app fails with the following error:
It happens in the following method, in the line where the
action.publishedByUser
is set.The following code does not pass
strictActionImmutability
check, which is enabled by default. This temporal fix disables this runtime check, but at some point of time, we should consider refactoring the code to use only immutable actions as the documentation suggests:https://ngrx.io/guide/store/configuration/runtime-checks