Skip to content

DS in ES6 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2016
Merged

DS in ES6 #2

merged 1 commit into from
Mar 28, 2016

Conversation

hemanth
Copy link
Contributor

@hemanth hemanth commented Mar 27, 2016

Rewrote files in ES6, hope you like it ;)

I had started this couldn't complete so doing this PR instead.

@benoitvallon
Copy link
Owner

Hey @hemanth,

Thank you, this is awesome. Would you mind creating new files for es6 versions instead? I would like to keep the es5 and es6 separated. I think es5 is not dead yet and by doing this the project could also be a way to see and appreciate the new things introduced by es6. I am thinking of keeping the actual file name for es5 and adding new files with the suffixe .es6.js for the es6 versions like:

es5: array.js
es5: array.es6.js

Thanks again, that's an amazing job.

@arrowrowe
Copy link

Hi, I had started some as well, many of which were naively implemented. Don't know if they help.

@benoitvallon
Copy link
Owner

If we are going to have the Data Structures part in es6, I thought it would be nice to have the Sorting Algorithms part as well so I started to add them in es6.

@benoitvallon
Copy link
Owner

@arrowrowe great resources, thanks

@hemanth
Copy link
Contributor Author

hemanth commented Mar 27, 2016

@benoitvallon Sure, will work on it.

@hemanth
Copy link
Contributor Author

hemanth commented Mar 28, 2016

@benoitvallon Done, would it make sense to organize ES5 and ES6 in separate dirs?

@benoitvallon
Copy link
Owner

@hemanth thanks for your work.
Yes probably, it would make the dir easier to compare. I will have a look at it today.

@benoitvallon benoitvallon merged commit e1613b0 into benoitvallon:master Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants