-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --paste-global-conf option #1304
Add --paste-global-conf option #1304
Conversation
…the PasteDeploy entrypoint from cli
for e in raw_global_conf: | ||
s = _compat.bytes_to_str(e) | ||
try: | ||
k, v = re.split(r'(?<!\\)=', s, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regular expression here is a raw string, so should there be only one backslash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore me. Right. The backslash here is not for character escape but for regular expression escape. Whole reason for the raw is to not have \\\\
.
👾 🌔 🚀
LGTM |
Maybe we should add to the docstring that it can be specified multiple times? Also, I wonder if |
|
…d adding more description in the docstring.
Thanks! |
Thanks for taking care of this! |
* Add --paste-global-conf option so users can pass arbitrary values to the PasteDeploy entrypoint from cli * Reflect the suggestions: `--paste-global-conf` => `--paste-global` and adding more description in the docstring.
While bootstraping gunicorn with
paster
(PasteScript) orpserve
(Pyramid) is now discouraged, no options are provided for PasteDeploy users to set global configuration variables from the commandline.This patch adds the new commandline option
--paste-global-conf KEY=VALUE
so that the users can pass arbitrary global_conf values to the PasteDeploy entrypoint.