Repository navigation
fix: Point package main to the compiled JavaScript entry - #215
Merged
Merged
Conversation
"main" referenced dist/src/converter/convertProject.ts, which the build never creates, so importing ts2esm as a library failed. It now points to the compiled .js file, next to which TypeScript also finds the .d.ts types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"main" in package.json pointed to
dist/src/converter/convertProject.ts, but the build only emits.jsand.d.tsfiles there. Importing ts2esm as a library (import {convertProject} from 'ts2esm') therefore failed; only the CLI worked."main" now points to
convertProject.js. TypeScript finds the types in the.d.tsfile next to it.