Implement package exports and subpath imports handling #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements smart handling of package exports and subpath imports to distinguish between legacy packages that need
.js
extensions and modern packages withexports
field that should remain unchanged.Problem
The current implementation adds
.js
extensions to all node_modules imports, but this doesn't work correctly for modern packages that use theexports
field in theirpackage.json
. This causes issues where:lodash
) need.js
extensions:'lodash/omit'
→'lodash/omit.js'
firebase-functions
) should remain unchanged:'firebase-functions/v1/https'
(already works correctly in ESM)Solution
Added intelligent package detection that checks if a node_modules package has an
exports
field:Key Changes
hasPackageExports()
utility inPathUtil.ts
that safely reads and parsespackage.json
files to detect theexports
fieldreplaceModulePath.ts
to check package exports before adding file extensions@types/node
Testing
This change maintains full backward compatibility while fixing the issue with modern packages that use the
exports
field.Fixes #129.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.