Improving handling of empty timestamps in the parser. #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thank you for the library :)
We have applied it to our particular use case and it does pretty good job. The only problem we've discovered is that our subtitles (which are auto-generated by 3rd party vendor), sometimes could have a bit strange entries with just empty text, i.e. it would specify some timestamp but would not specify any text/wording for that time interval, just an empty line. Let me show an example:
You see the section first section does not specify any text, just an empty line (an empty text, if you like). It was generating some PHP notices, so I opted to patch a bit the parser logic.