Don't try to remove cruft if null #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this happens when you have two charts on a page and you unmount them both. |
|
Yes, that is correct |
|
Yup! I was hit by the exact same issue. I applied this patch to my local fork and it worked like a charm. Thanks @tht13 ! @benjeffery would be great to have an official release with this patch. Running from a git fork is annoying because of the pre-compilation. |
|
I'm on paternity leave currently - will try to find a moment to merge this in the next few days. |
|
Released as v0.3.3. Thanks for reporting this. I'm still hoping for an upstream solution eventually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been getting a
cannot get parent node of nullerror when unmounting the component. This PR will check if cruft is null before attempting to remove it.