Optimize ensure_str and ensure_binary. #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found that large applications that have undergone a 2 -> 3 migration and wound up with a lot of six.ensure_str and six.ensure_binary calls could save 1-2% CPU usage by optimizing these for the common case. Further optimization could be done by replacing them with extension module implementations - assumed out of scope for the pure Python six project itself. Ideally all of these calls and use of six in people's code would be removed after there all need for any Python 2 compatibility is gone. But completing that kind of type cleanup requires a lot of human engineering time. This lowers the ongoing costs in the interim. Contributed by YouTube.
benjaminp
reviewed
May 19, 2020
Nope, that's a good idea for the future. |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that large applications that have undergone a 2 -> 3 migration
and wound up with a lot of six.ensure_str and six.ensure_binary calls
could save 1-2% CPU usage by optimizing these for the common case.
Further optimization could be done by replacing them with extension
module implementations - assumed out of scope for the pure Python six
project itself.
Ideally all of these calls and use of six in people's code would be
removed after there all need for any Python 2 compatibility is gone.
But completing that kind of type cleanup requires a lot of human
engineering time. This lowers the ongoing costs in the interim.
Contributed by YouTube.