Improve Container Build Process#1449
Open
pstoeckle wants to merge 1 commit intobenjaminjonard:1.7from
Open
Conversation
Owner
|
Hi, thanks for your contribution I'm currently working on release 1.8 with the newest versions of PHP and Symfony and was planning to drop the current Dockerfile in favor of the one called Dockerfile.frankenphp. I think your work is still applicable to this new image so I'll have a look once the new version is ready to release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I really like the project! So first of all thanks for creating/publishing it!
I have some improvements for the
Dockerfileresp. the container image build processnode:21image to build the JavaScript part without installing/uninstallingnodejs; remove the now unused dependenciesaarch64version oflibcurl-impersonateon arm-based machines/have thelwthiker/curl-impersonateversion as renovate-updatableENVvariablehadolintwarnings, e.g.,--no-install-recommendsset -eux ; cmd1 ; cmd2;syntax to which fails on unset var, avoids&&cascades, and helps debugging theDockerfileaptdeps.dockerignore, and add all needed files via exception rules, e.g.,!assets