Skip to content

Comments

Improve Container Build Process#1449

Open
pstoeckle wants to merge 1 commit intobenjaminjonard:1.7from
pstoeckle:1.7
Open

Improve Container Build Process#1449
pstoeckle wants to merge 1 commit intobenjaminjonard:1.7from
pstoeckle:1.7

Conversation

@pstoeckle
Copy link
Contributor

@pstoeckle pstoeckle commented Jan 7, 2026

Hi there,

I really like the project! So first of all thanks for creating/publishing it!
I have some improvements for the Dockerfile resp. the container image build process

  • use multi-stage builds/existing node:21 image to build the JavaScript part without installing/uninstalling nodejs; remove the now unused dependencies
  • Install aarch64 version of libcurl-impersonate on arm-based machines/have the lwthiker/curl-impersonate version as renovate-updatable ENV variable
  • Fixed some hadolint warnings, e.g., --no-install-recommends
  • Use set -eux ; cmd1 ; cmd2; syntax to which fails on unset var, avoids && cascades, and helps debugging the Dockerfile
  • Sorted the apt deps
  • exclude all files in the .dockerignore, and add all needed files via exception rules, e.g., !assets

@benjaminjonard
Copy link
Owner

Hi, thanks for your contribution

I'm currently working on release 1.8 with the newest versions of PHP and Symfony and was planning to drop the current Dockerfile in favor of the one called Dockerfile.frankenphp. I think your work is still applicable to this new image so I'll have a look once the new version is ready to release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants