Fix nukeop#1140 - context popups not appearing for tracks without thu…

…mbnails
benitofischer · Jan 14, 2022 · d2b2cd4 · d2b2cd4
1 parent 55a4000
commit d2b2cd4
Show file tree

Hide file tree

Showing 7 changed files with 969 additions and 463 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -52,9 +52,7 @@
     "husky": "^3.1.0",
     "lerna": "^3.22.1",
     "lint-staged": "^10.0.0-beta.14",
-    "sass-loader": "^12.1.0",
     "shx": "^0.3.3",
-    "style-loader": "^3.2.1",
     "typescript": "^4.2.4"
   },
   "optionalDependencies": {

diff --git a/packages/app/app/components/PlayQueue/QueuePopup/index.js b/packages/app/app/components/PlayQueue/QueuePopup/index.js
@@ -86,7 +86,6 @@ export const QueuePopup = ({
       position={isQueueItemCompact ? 'bottom right' : 'bottom center'}
       hideOnScroll
       on={null}
-      popperModifiers={{ preventOverflow: { boundariesElement: 'window' } }}
     >
       <StreamInfo
         dropdownOptions={dropdownOptions}

diff --git a/packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx b/packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx
@@ -25,6 +25,13 @@ describe('Play Queue container', () => {
     expect(component.asFragment()).toMatchSnapshot();
   });
 
+  it('should display a context popup on right click for tracks without thumbnails', async () => {
+    const { component } = mountComponent();
+    const track = component.getByTestId('queue-popup-uuid3');
+    await waitFor(() => fireEvent.contextMenu(track));
+    expect(component.asFragment()).toMatchSnapshot();
+  });
+
   it('should copy original track url to clipboard', async () => {
     const { component } = mountComponent();
     // eslint-disable-next-line @typescript-eslint/no-var-requires
@@ -88,7 +95,7 @@ describe('Play Queue container', () => {
   const mountComponent = mountedPlayQueueFactory(
     ['/dashboard'],
     buildStoreState()
-      .withTrackInPlayQueue()
+      .withTracksInPlayQueue()
       .withPlugins()
       .withConnectivity()
       .build()