Skip to content

Provide build and test instructions in README #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Conversation

sampottinger
Copy link
Collaborator

@sampottinger sampottinger commented Dec 4, 2019

Provide build and test instructions within the project README. Resolves #26.

Resolving #26, provide build and test instructions within the project README.
@sampottinger sampottinger requested a review from benfry December 4, 2019 18:32
@benfry
Copy link
Owner

benfry commented Dec 5, 2019

Let's put the build portion as a new README.md under build, though—otherwise the main page gets huge.

Responded to @benfry feedback on #42 (processing/processing4#42), breaking the README into two files with a new README in the build directory.
@sampottinger
Copy link
Collaborator Author

Thanks for the feedback @benfry. I addressed in processing/processing4@6ed36f7. Let me know if that looks good.

@benfry
Copy link
Owner

benfry commented Jan 7, 2020

Looks good, let's also add a link to the build instructions from that front page. I totally agree with your original sentiment of including them up front so they can be found.

@benfry benfry merged commit cde1a24 into master Jan 7, 2020
@benfry benfry deleted the updated-readme branch January 7, 2020 15:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are no build instructions
2 participants