Fix ALS loss calculation on GPU #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GPU ALS model would sometimes return incorrect results with the `calculate_training_loss` parameter enabled. This happend when the number_of_users * number_of_items was bigger than 2**31 due to an overflow in the loss function calculation. Fix and tests that would have caught this bug Closes #367 Closes #441
This was referenced Jun 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPU ALS model would sometimes return incorrect results with the
calculate_training_lossparameter enabled. This happend when the number_of_users * number_of_items was bigger than 2**31 due to an overflow in the loss function calculation.Fix and add tests that would have caught this bug
Closes #367
Closes #441