-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multigroup neutral model #185
Draft
mikekryjak
wants to merge
37
commits into
master
Choose a base branch
from
hot-neutrals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,063
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Floor prevents CX turning off. problem for CX with density channel
- When the hot neutrals approach the cold neutral temperature, wall reflection no longer turns them into cold neutrals. Prevents hot neutrals from becoming colder than cold neutrals by the wall.
Apply limiter/upwinding to both X and Y advection
Seems to work better for neutral perpendicular diffusion than MC.
Take field (Nn, Pn, NVn) and Dnn separately; only upwind the field, and use cell face average values for Dnn. Also add neutral_conduction switch.
target settings used in SOL and PFR regions, rather than SOL and PFR settings.
Seems to help with smoothness of profiles
Same as anomalous_diffusion, obtain flows in X and Y for output when diagnose = true. Note: Only saves perpendicular flux, not parallel flux.
- For debugging purposes
- added setting for pressure floor. Added temporary debug flags for using floored Nn and Pn in DnnNn and DnnPn calculation (otherwise they could unbalance and lead to density loss - need more testing). There is a secondary floor which kicks in at zero gradient, this is now linked to the primary floor (but 2 orders of magnitude below).
- Allows you to bias the CX sources towards either atom1 or atom2 which is particularly useful for the hot neutral model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The neutral fluid approximation breaks down in the core where the neutrals are so hot they are nearly collisionless.
We assume a single neutral distribution. This means that those hot neutrals have no choice but to conduct their heat (preheat) to the nearby cold SOL neutrals, even though in reality they would pass through and hit the wall. To mitigate this issue, we can impose a conduction heat flux limiter, but this traps the hot neutrals in the core and prevents them from heating the walls, while the cold neutral preheat is okay in the SOL but too low in the PFR.
A solution could be to have a new species called hot neutrals. Both cold and hot neutrals would have the same atomic reactions available, but cold neutrals are created only through puffing and thermal recycling, while hot neutrals are created only through charge exchange or fast recycling.
To do: