Unchained flux limiters + fast recycling #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to get model closer to Horsten thesis (2019). The net effect of these changes is to: - Increase heat conduction by 5/3 - Increase heat advection by 5/3 - Increase viscosity by 5/2 - Add viscous heating The atomic rates used in diffusion, viscosity, and heat conduction coefficients are still different from Horsten 2019.
Convert from viscous heating power to rate of change of pressure.
Intended to be similar to Wim Van Uytven et al "Assessment of advanced fluid neutral models for the neutral atoms in the plasma edge and application in ITER geometry" Nucl. Fusion 62 (2022) 086023 Significantly slows convergence; may be something wrong in implementation.
Previous commit accidentally reversed the sign of the cross-field particle flow, resulting in very poor convergence. Flux limits are now enabled by default.
- This is for testing and the Rnn term may be removed permanently later - The AFN limiters don't have this.
- For testing
Check if float option is < 0 rather than equal to -1. Remove some unused and commented-out code.
- Very simple expression at the moment, need to check later whether there are any factors missing from a detailed derivation - Unsure whether neutral energy source is energy or pressure. Previously neutral energy was T_FC * N and added to energy_source, which seems inconsistent.
The fast recycling energy wasn't being added to the actual energy source, only to the diagnostic energy source
- This allows the heat flow through the sheath to be used by other parts of the code
Field energy_flow_ylow should be shifted to non-aligned coordinates. In axisymmetric simulations this doesn't make a difference. Thanks Ben!
Heat flow now correctly calculated from ion sheath heat flow which is calculated in sheath_boundary_simple. sheath_boundary not yet supported. Improved variable names and comments for clarity
Further improvements to code clarity and readability
|
Development has been split off into other PRs. Limiter development: mikekryjak#6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new flux limiters have proven very difficult due to significant slowdowns. I am able to somehow get reasonable runtimes in the older version of neutral_model where the flux limiters are not chained together (2655106).
This PR is a merge of the above with the latest fast-recycling. It is temporary and allows me to get some results while we work on the latest version of the neutral model (#178).