Fix findDOMNode was called on an unmounted component.
#222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calling getScrollWidth (which triggers a findDOMNode) after a component is unmounted. Suggestions comes from a React blog post: https://reactjs.org/blog/2015/12/16/ismounted-antipattern.html
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=========================================
+ Coverage 75.77% 75.8% +0.03%
=========================================
Files 111 111
Lines 5110 5117 +7
Branches 366 367 +1
=========================================
+ Hits 3872 3879 +7
+ Misses 961 959 -2
- Partials 277 279 +2
Continue to review full report at Codecov.
|
|
Looks good! |
|
Thanks @bencripps, when do you think this will get published to npmjs.com? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a flag to track if component is still mounted in order to avoid… calling getScrollWidth (which triggers a findDOMNode) after a component is unmounted. Suggestions comes from a React blog post: https://reactjs.org/blog/2015/12/16/ismounted-antipattern.html