Skip to content

Update to stateGetter for non-immutable store #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2017

Conversation

bellmoose
Copy link
Contributor

Changes made to util/stateGetter and test/util/stateGetter.test

Checks to make sure stateItem is an immutable before doing the .get

@codecov-io
Copy link

codecov-io commented Sep 5, 2017

Codecov Report

Merging #179 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   75.98%   75.99%   +<.01%     
==========================================
  Files         112      112              
  Lines        5143     5144       +1     
  Branches      366      366              
==========================================
+ Hits         3908     3909       +1     
  Misses        958      958              
  Partials      277      277
Impacted Files Coverage Δ
src/util/stateGetter.js 89.65% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd94e7d...af04ec5. Read the comment docs.

@bencripps
Copy link
Owner

Thanks for adding the test case, but it looks like you've updated 73 files (most just adding new lines). Would you mind reverting those files back to the way they were?

@bellmoose
Copy link
Contributor Author

Yeah, lemme give that a try. Sorry new to this whole thing.

@bellmoose
Copy link
Contributor Author

Not sure if I've completely borked this, or if its right at this point.

@bencripps bencripps merged commit 9e5876a into bencripps:master Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants