Skip to content

bug #154 - updated editableFuncArgs to just take editorData #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2017

Conversation

Vanderslice
Copy link
Contributor

@Vanderslice Vanderslice commented Aug 11, 2017

Purpose: This resolves an issue with editableFunctionArgs returning undefined for the row.

The fix for 154, cfe896d, swapped the editableFuncArgs' row to editorData instead of editorState but is still attempting to get the rowId for the editorData which returns undefined because the editorData is already the row we're acting on.

For example, the following column would always return false because of row being undefined:

    editable: ({ row }) => {
        if (row && row.values) {
            return row.values.name === 'Michael Jordan';
        }
        return false;
    },

@codecov-io
Copy link

codecov-io commented Aug 11, 2017

Codecov Report

Merging #171 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   75.96%   75.98%   +0.01%     
==========================================
  Files         112      112              
  Lines        5143     5143              
  Branches      366      366              
==========================================
+ Hits         3907     3908       +1     
  Misses        958      958              
+ Partials      278      277       -1
Impacted Files Coverage Δ
...rc/components/layout/table-row/row/cell/Editor.jsx 68.49% <50%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09e975e...2aa8248. Read the comment docs.

@bencripps bencripps merged commit 2fd5e1d into bencripps:master Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants