[WIP] util/lastupdate - Updated updateGetter to use reducerKeys to allow fo… #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r passing of reducerKeys via grid props
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 77.23% 77.26% +0.03%
==========================================
Files 112 112
Lines 2728 2732 +4
Branches 276 276
==========================================
+ Hits 2107 2111 +4
Misses 412 412
Partials 209 209
Continue to review full report at Codecov.
|
Vanderslice
changed the title
Vanderslice
changed the title
|
Changes look good! I'll test this tonight, thanks! |
|
Code looks good -- let's get some testing incorporated with this. Let me know if you run into any issues; I can help. |
…ted reducers is wip
|
Closing this PR, changes have been incorporated into master. See #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r passing of reducerKeys via grid props
To resolve issue #123. Working on adding additional testing around this use case.