fix: nil derefence on gazelle update-repos #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Bartlett <james@gimletlabs.ai>
|
@ColinHeathman any chance we can get this in? Just ran into this same problem! |
ColinHeathman
approved these changes
Oct 20, 2023
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
bazel //:gazelle_with_js update-reposin a repo wheregazelle_with_jshas this extension enabled led to a nil dereference attempting to convert nil toJsConfigs. This fixes it by initializing the root js config inRegisterFlags, which mimics the way that gazelle does it internally forgolang.