ENH – Add skglm SmoothQuantileRegressor solver and related improvements (add. python based solvers, sparse dataset (finance), lambda_max fix)#13
Open
floriankozikowski wants to merge 7 commits intobenchopt:mainfrom
Conversation
skglm SmoothQuantileRegressor solver
…dd fallbacks for solvers and verified stopping criterion
skglm SmoothQuantileRegressor solverskglm SmoothQuantileRegressor solver + various other python based qr solver
skglm SmoothQuantileRegressor solver + various other python based qr solverskglm SmoothQuantileRegressor solver and related improvements (add. python based solvers, sparse dataset (finance), lambda_max fix)
Author
|
Hi @Badr-MOUFAD. I wanted to do some benchmarking for the new skglm QuantileHuber solver. In this run, I also added a few other solvers & reviewed the lambda max computation in the objective.py, which I think is more accurate now. I am happy for review. If it's too much in one PR let me know and I can delete stuff again. I did the benchmark for myself and thought it might be useful to push here. P.S.: I also made a script for an R solver for quantile regression (as R is more widely used for these things), if you want I can add this also to the repo (either in this PR or probably better in a new seperate PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of the PR
skglm.experimental.SmoothQuantileRegressor was first introduced in sklearn-contrib/skglm #312.
This PR adds this to this benchopt benchmark.
While wiring it into benchmark_quantile_regression, I noticed a few gaps that prevented fair comparisons and reproducible results, so I addressed them in the same pass (sparse dataset (finance), lambda_max).
For broader comparison, I also added various other python based solvers.
Contributions of the PR