Open
Conversation
414owen
force-pushed
the
os/pretty-durations
branch
from
627f3b2 to
6992a91
Compare
414owen
force-pushed
the
os/pretty-durations
branch
3 times, most recently
from
c049ca9 to
8d0f52a
Compare
Member
|
Thank you for your contribution @414owen! Could you please have a look at the failing tests and lint checks and fix those issues? |
414owen
force-pushed
the
os/pretty-durations
branch
4 times, most recently
from
9592783 to
bfec205
Compare
414owen
force-pushed
the
os/pretty-durations
branch
from
bfec205 to
e069778
Compare
Contributor
Author
|
@ktrz this should be ready for another pair of eyes |
Member
|
Hey @414owen Thank you for fixing the lint issues and adding tests! I've noticed that this only works for Would you mind adding handling for those cases as well and also add some test cases specifically for the things you are trying to improve? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark reports that show, eg. 472666693ns/iter, are very difficult to scan.
This change formats benchmarks measured in
ns/iterwith a more human readable duration.Example output: 414owen/outlines-core#7
@ktrz