Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Grafana Template #3

Merged
merged 3 commits into from
Mar 19, 2018
Merged

Update Grafana Template #3

merged 3 commits into from
Mar 19, 2018

Conversation

Coolfeather2
Copy link
Contributor

@Coolfeather2 Coolfeather2 commented Mar 16, 2018 •
edited
Loading

Pull request summary

Brief description:

Modifying the Grafana template to automatically swap username

At a glance:

  • This is a minor change
  • Changes are backwards-compatible
  • Changes are urgent

Added features:

  • User Variable in Grafana Dashboard
  • Memory usage stat collection

Changes to existing features:

  • None

Bugfixes:

  • None

Testing checklist:

  • Codebase compiles with current tsconfig configuration
  • Deployed and tested changes on public server

@Coolfeather2
Copy link
Contributor Author

Don't merge just yet, I'll add memory stats too

@Coolfeather2
Copy link
Contributor Author

Coolfeather2 commented Mar 17, 2018 •
edited
Loading

ah shoot #B in "Memory" isn't showing up as I want

@Coolfeather2
Copy link
Contributor Author

Good to merge when approved

@bencbartlett bencbartlett merged commit 9bd756d into bencbartlett:master Mar 19, 2018
NekoKetsu referenced this pull request in NekoKetsu/Overmind May 14, 2023
@schealex
Merge pull request #3 from ikiris/isplayer
7279c66 
lol fixed playerhostiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coolfeather2 @bencbartlett