Changed msb/lsb constructor #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benasher44
reviewed
Jun 25, 2019
benasher44
approved these changes
Jul 1, 2019
|
Looks good! I'll merge once conflicts are resolved. Sorry for the delay! |
Changed Java compatible constructor to a freestanding function. This is in relation to #29 and the problem that defining constructors for our class is something that hinders us in general from being compatible with different kinds of native implementations. The goal is that we can define the `Uuid` class as a `typealias` in Java but we cannot, for instance, require a `Uuid(data: ByteArray)` constructor since it is already defined and private. There might be the possibility to overwrite this somehow with a freestanding function of the same name but I believe that it is simpler to just go for freestanding functions for everything and stick with the proper naming for them. Should make for a cleaner API overall. I also improved the CHANGELOG a little further and please note that this change is not breaking because we never released the `Uuid(msb: Long, lsb: Long)` constructor.
|
This change is now breaking, but i'll do a follow-up PR to deprecate the previous contructor |
2 tasks
benasher44
added a commit
that referenced
this pull request
Dec 29, 2019
This adds the required deprecation to make #52 not breaking
|
FYI: ended up further changing this in #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or Changes Proposed
Uuidclass as atypealiasin Java but we cannot, for instance, require aUuid(data: ByteArray)constructor since it is already defined and private. There might be the possibility to overwrite this somehow with a freestanding function of the same name but I believe that it is simpler to just go for freestanding functions for everything and stick with the proper naming for them. Should make for a cleaner API overall.CHANGELOGentries a little.Please note that this change is not breaking because we never released the
Uuid(msb: Long, lsb: Long)constructor.PR Checklist