Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace travis with GitHub action #123

Merged
merged 8 commits into from
Sep 28, 2021
Merged

Replace travis with GitHub action #123

merged 8 commits into from
Sep 28, 2021

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Sep 19, 2021

Fixes #119

@rejas
Copy link
Collaborator Author

rejas commented Sep 26, 2021

so this PR would be ready to be merged @ben-eb. only thing questionable is the coverage part which would need a secret token generated (which only @ben-eb can do)

@rejas rejas mentioned this pull request Sep 26, 2021
Merged
ben-eb
ben-eb reviewed Sep 26, 2021
View reviewed changes
Copy link
Owner

@ben-eb ben-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If it's needed I've regenerated the repo token for coveralls and put it in the COVERALLS_REPO_TOKEN secret.

.github/workflows/node-ci.js.yml Outdated Show resolved Hide resolved
ben-eb
ben-eb approved these changes Sep 28, 2021
View reviewed changes
Copy link
Owner

@ben-eb ben-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@rejas rejas merged commit 99614f5 into master Sep 28, 2021
@rejas rejas deleted the github branch September 28, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-eb ben-eb ben-eb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace travis.org with travis.com or github-actions
2 participants
@rejas @ben-eb