Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better types remove outdated syntax #142

Closed
wants to merge 8 commits into from
Closed

Conversation

7heMech
Copy link
Contributor

@7heMech 7heMech commented May 4, 2024

In this pr:

  • I add return types and add more jsdoc
  • I replaced outdated substr syntax

@7heMech
Copy link
Contributor Author

7heMech commented May 4, 2024

It also improves build times

@bellstrand
Copy link
Owner

As I wrote in your issue, the bun part has a couple of more moving parts that would need to be resolved first. (dependabot, test/release workflows etc). and Dependabot would need to be replaced since they don't support bun yet, dependabot/dependabot-core#6528

So if you could move all things related to bun to another PR, we can merge the other things right away! :)

@7heMech
Copy link
Contributor Author

7heMech commented May 6, 2024

As I wrote in your issue, the bun part has a couple of more moving parts that would need to be resolved first. (dependabot, test/release workflows etc). and Dependabot would need to be replaced since they don't support bun yet, dependabot/dependabot-core#6528

So if you could move all things related to bun to another PR, we can merge the other things right away! :)

Fair enough bun will have more compatibility with jest in the future, so we could even avoid modifying the tests a lot.

@7heMech 7heMech changed the title Use bun for tests, better types Better types remove outdated syntax May 6, 2024
@7heMech
Copy link
Contributor Author

7heMech commented May 6, 2024

I think these are the changes not related to bun.

@7heMech
Copy link
Contributor Author

7heMech commented May 6, 2024

Actually, I'll close this since everything is in my other pr I think

@7heMech 7heMech closed this May 6, 2024
@7heMech 7heMech deleted the master branch May 6, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants