Skip to content

fix: mengignore peer deps popperjs yang tidak dipakai bootstrap #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2022
Merged

fix: mengignore peer deps popperjs yang tidak dipakai bootstrap #319

merged 1 commit into from
May 15, 2022

Conversation

reacto11mecha
Copy link
Collaborator

Deskripsi (Description)

  • saya menambahkan algoritma terbaru
  • saya memperbaiki algoritma yang sudah ada
  • saya menambahkan materi/sub materi belajar
  • saya memperbaiki materi/sub materi belajar
  • saya menambah dokumentasi
  • saya memperbaiki dokumentasi

Contributor Requirements (Syarat Kontributor)

  • saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
  • saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment

saya menggunakan (im used):

  • os = linux

Testing

  • doctesting js
  • lint testing eslint

@reacto11mecha reacto11mecha requested a review from a team May 11, 2022 22:14
@auto-add-label auto-add-label bot added the bug Something isn't working label May 11, 2022
@reacto11mecha
Copy link
Collaborator Author

Error yang dimaksud ada di #318 #317

nomadkode
nomadkode approved these changes May 15, 2022
View reviewed changes
Copy link
Contributor

@nomadkode nomadkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mergify mergify bot merged commit cc44a7d into bellshade:main May 15, 2022
@reacto11mecha reacto11mecha deleted the fix/artifact-problem branch May 2, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomadkode nomadkode nomadkode approved these changes

@dhafitf dhafitf dhafitf approved these changes

@hasheemi hasheemi Awaiting requested review from hasheemi hasheemi is a code owner

@KimmyKx KimmyKx Awaiting requested review from KimmyKx KimmyKx is a code owner

@rolandowebdev rolandowebdev Awaiting requested review from rolandowebdev

@azqilana azqilana Awaiting requested review from azqilana

@rizkyikhwan rizkyikhwan Awaiting requested review from rizkyikhwan rizkyikhwan is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reacto11mecha @nomadkode @dhafitf