Skip to content

Menambahkan nav badge di Basic dan membuat Pengenalan OOP #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 24, 2021
Merged

Menambahkan nav badge di Basic dan membuat Pengenalan OOP #218

merged 8 commits into from
Nov 24, 2021

Conversation

wahyall
Copy link
Collaborator

@wahyall wahyall commented Nov 23, 2021 •
edited
Loading

Closes

Deskripsi (Description)

  • saya menambahkan algoritma terbaru
  • saya memperbaiki algoritma yang sudah ada
  • saya menambahkan materi/sub materi belajar
  • saya memperbaiki materi/sub materi belajar
  • saya menambah dokumentasi
  • saya memperbaiki dokumentasi

Contributor Requirements (Syarat Kontributor)

  • saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
  • saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment

saya menggunakan (im used):

  • os = windows

Testing

  • doctesting js
  • lint testing eslint

Maintainer

@wahyall wahyall requested review from reacto11mecha and a team November 23, 2021 06:42
rizkyikhwan
rizkyikhwan approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@rizkyikhwan rizkyikhwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

KimmyKx
KimmyKx approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@KimmyKx KimmyKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rolandowebdev
rolandowebdev reviewed Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@rolandowebdev rolandowebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

reacto11mecha
reacto11mecha approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@reacto11mecha reacto11mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantap, om. LGTM

azqilana
azqilana approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@azqilana azqilana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oke

@reacto11mecha reacto11mecha linked an issue Nov 23, 2021 that may be closed by this pull request
Class / Pengenalan class #220
Closed
dhafitf
dhafitf approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@wahyall wahyall changed the title Menambahkan nav badge pada materi Basic Menambahkan nav badge di Basic dan membuat Pengenalan OOp Nov 24, 2021
@wahyall wahyall changed the title Menambahkan nav badge di Basic dan membuat Pengenalan OOp Menambahkan nav badge di Basic dan membuat Pengenalan OOP Nov 24, 2021
hasheemi
hasheemi approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@hasheemi hasheemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sip LGTM

rizkyikhwan
rizkyikhwan approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@rizkyikhwan rizkyikhwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantap om, LGTM🚀

azqilana
azqilana approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@azqilana azqilana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprove

dhafitf
dhafitf approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rolandowebdev
rolandowebdev approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@rolandowebdev rolandowebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@mergify mergify bot merged commit 8391efa into bellshade:main Nov 24, 2021
@wahyall wahyall deleted the nav-basic branch December 3, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azqilana azqilana azqilana approved these changes

@rolandowebdev rolandowebdev rolandowebdev approved these changes

@reacto11mecha reacto11mecha reacto11mecha approved these changes

@hasheemi hasheemi hasheemi approved these changes

@rizkyikhwan rizkyikhwan rizkyikhwan approved these changes

@dhafitf dhafitf dhafitf approved these changes

@KimmyKx KimmyKx KimmyKx approved these changes

Assignees

@wahyall wahyall

Labels
javascript file markdown files ready-to-merge request tim javascript untuk review js file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class / Pengenalan class
8 participants
@wahyall @azqilana @rolandowebdev @reacto11mecha @hasheemi @rizkyikhwan @dhafitf @KimmyKx