Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dep updates 050324 #18

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Feat/dep updates 050324 #18

merged 3 commits into from
Mar 6, 2024

Conversation

Tristano8
Copy link

No description provided.

Flake lock file updates:

• Updated input 'flake-utils':
    'github:numtide/flake-utils/4022d587cbbfd70fe950c1e2083a02621806a725' (2023-12-04)
  → 'github:numtide/flake-utils/d465f4819400de7c8d874d50b982301f28a84605' (2024-02-28)
• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/eef6384e98b48f0c12f8e74a387f4427959f1bdf' (2023-12-11)
  → 'github:nixos/nixpkgs/08a2dc8fd3196a6efbb9a0d0b160ab4e452e19bc' (2024-03-05)
Copy link
Member

@JackKelly-Bellroy JackKelly-Bellroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies support for GHC 9.8. Have you tested with it? If so, can you try updating tested-with and regenerating CI?

@Tristano8
Copy link
Author

Oh i thought 4.19 was 9.6 - i'll test now (or let CI do it)

@Tristano8
Copy link
Author

The update to wai-handler-hal-example made the same bounds change - should that also have been tested with 9.8?

@JackKelly-Bellroy
Copy link
Member

Probably yeah

@@ -21,6 +21,7 @@
"ghc92"
"ghc94"
"ghc96"
"ghc98"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you were able to build/get a shell for this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will tell you in 18 hours. CI gives me some confidence at least

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if it evaluates, everything else is gravy really

@Tristano8 Tristano8 merged commit 1045267 into master Mar 6, 2024
14 checks passed
@JackKelly-Bellroy JackKelly-Bellroy deleted the feat/dep-updates-050324 branch March 12, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants