lib/internal/blob.js: fix Blob.stream() for nodejs#48668 nodejs#48916

Add lacked calling resolve() for finish ReadableStream source.pull(). Fixes: nodejs#48668 Fixes: nodejs#48916 Fixes: nodejs#48232 Refs: 8cc1438
bellbind · Jul 27, 2023 · 5a661b9 · 5a661b9
1 parent 1eae568
commit 5a661b9
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/internal/blob.js b/lib/internal/blob.js
@@ -360,6 +360,11 @@ class Blob {
             queueMicrotask(() => {
               if (c.desiredSize <= 0) {
                 // A manual backpressure check.
+                if (this.pendingPulls.length !== 0) {
+                  // A case of waiting pull finished (= not yet canceled)
+                  const pending = this.pendingPulls.shift();
+                  pending.resolve();
+                }
                 return;
               }
               readNext();

diff --git a/test/parallel/test-blob.js b/test/parallel/test-blob.js
@@ -269,6 +269,19 @@ assert.throws(() => new Blob({}), {
   reader.closed.then(common.mustCall());
 })().then(common.mustCall());
 
+(async () => {
+  const b = new Blob(['A', 'B', 'C']);
+  const stream = b.stream();
+  const chunks = [];
+  const decoder = new TextDecoder();
+  await stream.pipeTo(new WritableStream({
+    write(chunk) {
+      chunks.push(decoder.decode(chunk, { stream: true }));
+    }
+  }));
+  assert.strictEqual(chunks.join(''), 'ABC');
+})().then(common.mustCall());
+
 (async () => {
   const b = new Blob(Array(10).fill('hello'));
   const stream = b.stream();