Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ViteApp] support for linter, typecheck and ci #696

Merged
merged 14 commits into from
Oct 27, 2021
Merged

Conversation

belgattitude
Copy link
Owner

@belgattitude belgattitude commented Oct 27, 2021

Follow up from #661

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2021

🦋 Changeset detected

Latest commit: d7b36af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nextjs-monorepo-example-web-app – ./apps/web-app

🔍 Inspect: https://vercel.com/belgattitude/nextjs-monorepo-example-web-app/3TPaUmmAPGEC3XjouiHXqF5BdkWo
✅ Preview: https://nextjs-monorepo-example-web-app-git-fix-yarn-lock-belgattitude.vercel.app

nextjs-monorepo-example-blog-app – ./apps/blog-app

🔍 Inspect: https://vercel.com/belgattitude/nextjs-monorepo-example-blog-app/DiBeNtNw7SzkJt4b6Sx35RaRvMpm
✅ Preview: https://nextjs-monorepo-example-blog-app-git-fix-yarn-lock-belgattitude.vercel.app

@codeclimate
Copy link

codeclimate bot commented Oct 27, 2021

Code Climate has analyzed commit d7b36af and detected 0 issues on this pull request.

View more on Code Climate.

@belgattitude
Copy link
Owner Author

belgattitude commented Oct 27, 2021

@ekafyi just for info, I've changed/added these little improvements

  • Add support for eslint / lint-staged
  • Add a CI action to check the vite-app too (lint, typecheck & build)
  • Fixed the tsconfig path... The barrel was missing, it's not very intuitive but it's needed.

The rest is very minor, like pinlock deps and refresh the lock. One thing, to avoid having boundaries problems, I've added eslint* as devDependency to the workspace too.

Hey thanks for your example, I'll try to add a sandbox later this week.

@belgattitude belgattitude deleted the fix-yarn-lock branch October 27, 2021 18:08
This was referenced Oct 27, 2021
@ekafyi
Copy link
Contributor

ekafyi commented Oct 28, 2021

Brilliant! Good job detecting the missing barrel issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants