Skip to content

Fixing edge case with null coalescing #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2025
Merged

Fixing edge case with null coalescing #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f333dbd
Fixing edge case with null coalescing
belav Aug 16, 2025
eb0933f
Better fix with only a couple minor edge cases that aren't ideal
belav Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 56 additions & 6 deletions Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/BinaryExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,62 @@ private static List<Doc> PrintBinaryExpression(SyntaxNode node, PrintingContext
var binaryOnTheRight = binaryExpressionSyntax.Kind() == SyntaxKind.CoalesceExpression;
if (binaryOnTheRight)
{
docs.Add(
Node.Print(binaryExpressionSyntax.Left, context),
Doc.Line,
Token.Print(binaryExpressionSyntax.OperatorToken, context),
" "
);
var chain = 0;
var possibleInvocation = binaryExpressionSyntax.Left;
while (possibleInvocation is not null)
{
if (possibleInvocation is InvocationExpressionSyntax invocationExpression)
{
possibleInvocation = invocationExpression.Expression;
chain++;
}
else if (
possibleInvocation
is MemberAccessExpressionSyntax memberAccessExpressionSyntax
)
{
possibleInvocation = memberAccessExpressionSyntax.Expression;
chain++;
}
else if (
possibleInvocation
is ConditionalAccessExpressionSyntax conditionalAccessExpressionSyntax
)
{
possibleInvocation = conditionalAccessExpressionSyntax.Expression;
chain++;
}
else if (
possibleInvocation
is ElementAccessExpressionSyntax elementAccessExpressionSyntax
)
{
possibleInvocation = elementAccessExpressionSyntax.Expression;
chain++;
}
else
{
possibleInvocation = null;
}
}
var leftDoc = Node.Print(binaryExpressionSyntax.Left, context);
if (chain > 3)
{
docs.Add(
Doc.Group(leftDoc, Doc.Line),
Token.Print(binaryExpressionSyntax.OperatorToken, context),
" "
);
}
else
{
docs.Add(
leftDoc,
Doc.Line,
Token.Print(binaryExpressionSyntax.OperatorToken, context),
" "
);
}
}

var possibleBinary = binaryOnTheRight
Expand Down
25 changes: 25 additions & 0 deletions Src/CSharpier.Tests/FormattingTests/TestFiles/cs/BinaryExpressions.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,31 @@ class TestClass
someLongValue__________________________________________
) ?? someOtherValue;

var x =
someValue
.Property.CallLongMethod_____________________________________()
.CallMethod__________()
?? throw new Exception();

var x =
someValue
.Property.CallLongMethod_____________________________________()
.CallLongMethod___________________________________________________()
?? throw new Exception();

return SomeObject.CallSomeMethod___________()
?? SomeObject.CallSomeMethod___________()
?? new SomeObject();

var storeObject =
entityType.GetSchemaQualifiedTableName()
?? entityType.GetInsertStoredProcedure()?.GetSchemaQualifiedName()
?? entityType.GetDeleteStoredProcedure()?.GetSchemaQualifiedName()
?? entityType.GetUpdateStoredProcedure()?.GetSchemaQualifiedName();

return parameterDescriptor.BindingInfo.Binder
?? Binders.GetBinder(parameterDescriptor.ParameterType);

var notIdealSee355 =
variable
.Replace(someParameter_______________________, '.')
Expand Down
Loading