-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement CLI Commands to SubCommands #1333
base: main
Are you sure you want to change the base?
Conversation
I only had time to scan it quick, but yeah I this looks like what I was thinking, breaking apart the commands so it is clear which options apply to which command. |
Ok i am finished. You could go for a review. One thing I was not sure about was which option should be available for the check command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm going to let @belav do the final merge though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally sure what options are needed for check, I'm guessing there will be a few from format that need to be added to check. Probably these three
--no-msbuild-check
--include-generated
--compilation-errors-as-warnings
It is also possible that --no-cache
would apply.
I can always merge for now and figure it out later unless you wanted to take it on in the same PR. Sorry for the delay in getting back to this, and thanks for the contribution!
As you want. You can also ping me when you figured it out. |
I started working on creating subcommands.
Could I get feedback for this? Is this the direction you want it to go?
It would be good for me when we could define all commands with the possible options