-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVG restyle to match vscode theme #26
base: master
Are you sure you want to change the base?
Add SVG restyle to match vscode theme #26
Conversation
@beicause I used the selection background color for the nodes and it isn't ideal in every theme, but in most of them it looks good. |
I think we'd better to theme the graphviz( .dot ) file directly. Changing the style of svg doesn't affect the .dot file we save. |
@beicause Sure! Should we have this as a temporary solution and then I can open an issue to migrate the solution to the other end of the file generation? With this strategy, we would have themes for the graphs right away. |
I have no reason to merge this PR now which adds unnecessary complexity if there is a better approach. Let's improve it firstly. |
@beicause I was investigating the options and AFAIK that the color palette is only available at the web view step - we could use some placeholders and interpolate them, but this would add some complexity and processing to the rendering step too. Do you have an idea on how to approach this? Thank you. Edit: My previous assumptions were incorrect. |
Summary
Intercept the SVG generated by graphviz and change the colors according to the vscode current theme.
Address the #24 "Make graph nicer." milestone
How it works
Explore the graph using a BFF algorithm, for each node, change the children's values according to their classes.
Evidences