-
Notifications
You must be signed in to change notification settings - Fork 100
Use Haskell instead of bash in the installer #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Having trouble with Travis where the vim plugin install is taking way too long: https://travis-ci.org/jship/haskell-vim-now/builds/243505406?utm_source=github_status&utm_medium=notification This doesn't happen on my local Windows box. Shooting to reproduce this on my Mac tomorrow. Potentially a problem with |
…y too long on the plugin install.
Looks like https://travis-ci.org/jship/haskell-vim-now/jobs/243507578 got passed the plugin install via use of |
Build 9 from my fork is green when helper binary install is skipped: https://travis-ci.org/jship/haskell-vim-now/builds/243786289?utm_source=github_status&utm_medium=notification Build 8 timed out. The CI build for this pull request (https://travis-ci.org/begriffs/haskell-vim-now/builds/243786312?utm_source=github_status&utm_medium=notification) failed because of the existing HVN install. |
HaskellVimNow.hs
Outdated
deriving (Show) | ||
|
||
defaultRepo :: Text | ||
defaultRepo = "https://github.com/jship/haskell-vim-now.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried rebuilding on CI without cache, but the build still fails. I think the problem is this default repo path. It has already cloned the repo from my account, and then the new path conflicts:
The source repository path [https://github.com/jship/haskell-vim-now.git] does not match the
origin repository of the existing installation [https://github.com/begriffs/haskell-vim-now.git].
Please remove the existing installation [/home/travis/.config/haskell-vim-now] and try again.
Thanks - updated it to the main repo. |
So I've been thinking about this PR. The changes are enormous (thanks for your hard work), is there a way to maybe start more gradually, like keep the bash scripting for the majority of the installer? We could delegate to a turtle Haskell script for one of the tasks you mentioned is tricky in bash. A little time would verify that introducing the Haskell bit is stable for everybody. Then we could start increasing the amount of Haskell. I know it's nice to switch over entirely for Windows support, but I anticipate one big rewrite as introducing a lot of moving parts that could be difficult to debug. |
The gradual introduction sounds very reasonable to me. A couple good candidate areas:
The Let me know what you think. Should we close this PR? I can open a new one with just whatever we decide on. |
Let's try I'll close this PR and you can open another just for that part. |
PR for Haskell-ifying the installer.