Skip to content

Fedora requires installing 'par' #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tsoernes
Copy link

@tsoernes tsoernes commented Jun 9, 2017

Also, I suggest detecting if neovim is installed and if so then skip installing vim.

@begriffs
Copy link
Owner

Thanks for the improvement. I don't see the part about the neovim check in the commits -- are you still working on it?

@tsoernes
Copy link
Author

No, I'm unsure how to do it in a way that works across platforms

@begriffs
Copy link
Owner

begriffs commented Jul 2, 2017

The other case statements use cmdpkg par par, is there a reason to do it differently for fedora?

@begriffs
Copy link
Owner

@tsoernes any opinion about my cmdpkg question?

@tsoernes
Copy link
Author

tsoernes commented Jul 19, 2017

I'm not entirely sure why some packages are echoed and some are called with cmdpkg. As long as the package name is clearly mentioned if missing it's fine, bonus points if the installer script automatically calls dnf install for the required packages.

@begriffs begriffs closed this in 96bf144 Jul 27, 2017
@begriffs
Copy link
Owner

Thanks again for pointing this issue out. I fixed it by installing par more uniformly on all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants