Get LTS-8.5 working #238

jship · 2017-03-22T03:23:44Z

Pin a few things to older LTS versions to make install from scratch less painful when using LTS-8.

~~Move hindent to the main install list as it no longer requires a specific pinned nightly (Hindent 5 is in LTS-8.5).~~

Call hoogle generate instead of hoogle data.

jship · 2017-03-23T01:46:16Z

@begriffs: Played around with this to try and get travis working, but Travis seems stuck on using LTS-7.2. I checked out the travis config and it doesn't look like haskell-vim-now is testing multiple GHC/LTS versions.

Is there a way to reset this in the Travis build box(es) so it starts using LTS-8.5? If so, I'll revert the 3 commits I put in today from experimentation.

begriffs · 2017-03-23T04:06:02Z

Thansk @jship, whenever I see this icon on a pull request I know there are going to be great changes!

I can clear the build cache on CI, but wondering whether it is currently simulating a problem that an actual user would experience if they had previously installed haskell-vim-now. What do you think?

jship · 2017-03-23T21:14:13Z

Thank you!

Great point about previous installs. I started from scratch for GHC8 when I made this PR, and will experiment with getting Travis happy on the older LTS. Shooting to play around with it tonight or early next week.

jship · 2017-03-24T03:39:03Z

Travis #115 build "passed" but timed out after everything completed successfully. Had to download a couple different GHC versions, which ate up time.

Squashed the commits and Travis #116 is going now. It still had to download a GHC and rebuild helper binaries which is strange - thought they would've been cached.

Maybe Travis doesn't cache on timeout?

It's painful on the initial install to have to get a couple different GHC versions, but from my testing, this will work fine for LTS-7.3 (what Travis is using) and LTS-8.5 (what I'm using). Users hopefully won't have to muck around in their global stack.yaml's.

SX91 · 2017-03-27T12:28:53Z

@jship that is a bad idea to overcomplicate installer that way.
@begriffs need some better and clearer way to "fix" this.

begriffs · 2017-03-27T16:19:10Z

We may just want to have a dependencies.cabal and stack.yaml file for the the helper binaries.

Here's a cabal file to declare the dependencies:

name:                dependencies
version:             0.1.0.0
synopsis:            helper binaries for vim
homepage:            https://github.com/begriffs/haskell-vim-now
license:             MIT
author:              Joe Nelson
maintainer:          cred+github@begriffs.com
category:            Development
build-type:          Simple
cabal-version:       >=1.10

library
  build-depends:       base >=4.9 && <4.10
                     , apply-refact
                     , codex
                     , ghc-mod
                     , hasktags
                     , hlint
                     , hoogle
                     , hscope
                     , pointfree
                     , pointful
  default-language:    Haskell2010

When I just ask cabal: cabal install --only-dependencies --reorder-goals and then cabal freeze I get this list of pinned versions that I think is able to install all the newest binaries: https://gist.github.com/begriffs/d655e8628e7f14f8f7ab51e6762190fc

Alternately doing a stack init --solver for the cabal file produces

resolver: lts-7.20
packages:
- '.'
extra-deps:
- codex-0.5.0.2
- hasktags-0.69.3
- hscope-0.4.3
- machines-directory-0.2.1.0
- machines-io-0.2.0.13
- pointfree-1.1.1.2
flags: {}
extra-package-dbs: []

jship · 2017-03-28T03:38:20Z

@begriffs Great idea - I'll experiment with this sometime this week.

jship · 2017-03-30T00:56:47Z

Hmm, Travis failed but local install passed for me. Will try again locally using LTS-7.3 to match Travis.

jship · 2017-03-30T01:18:20Z

Coming from an older version of stack: commercialhaskell/stack#2969

invalid-cabal-flag-settings was removed from stack list-dependencies output as a special case.

…versions of stack.

jship · 2017-03-30T02:21:04Z

Travis failed on rts - another bogus dependency from stack list-dependencies. Let's see how it goes with the latest commit to filter it out too.

jship · 2017-03-30T03:09:33Z

Hooray! Travis checks out.

mingyuguo · 2017-04-04T11:23:18Z

This version works great! (The master branch unfortunately doesn't work for me)

jiakai0419 · 2017-04-04T12:57:05Z

@mingyuguo how to use this version.

mingyuguo · 2017-04-04T13:20:19Z

Clone it into .config/haskell-vim-now
Run the original script with one change (comment out the line that calls check_repo_change around line 95)

jship · 2017-04-04T13:26:27Z

You can clone it anywhere and then specify the location when you run the install script with --repo.

I have my fork at ~/git/haskell-vim-now. I usually run:

cd ~/git/haskell-vim-now
bash install.sh --repo .

begriffs · 2017-04-04T14:04:36Z

scripts/setup.sh

-  stack --resolver nightly-2016-12-28 install hindent --verbosity warning ; RETCODE=$?
-  [ ${RETCODE} -ne 0 ] && exit_err "hindent installation failed with error ${RETCODE}."
+  # Install ghc-mod via active stack resolver for maximum out-of-the-box compatibility.
+  stack --resolver ${STACK_RESOLVER} install ghc-mod --verbosity warning ; RETCODE=$?


Could you include cabal-install in this one as well rather than having a separate step below?

No problem.

begriffs · 2017-04-04T14:05:35Z

scripts/setup.sh

+  stack --resolver ${STACK_RESOLVER} install ghc-mod --verbosity warning ; RETCODE=$?
+  [ ${RETCODE} -ne 0 ] && exit_err "Installing ghc-mod failed with error ${RETCODE}."
+
+  # Install hindent via pinned LTS to ensure we have version 5.


I think you're right about this one...I tried adding hindent >= 5.0 to the dependencies cabal file and that breaks the solver. Guess we have to do it separately like you did.

Yes, it's a little frustrating that we have to manually install hindent. The vim config expects hindent 5 and I'd rather not regress to hindent 4 to match the solver version.

begriffs · 2017-04-04T14:07:22Z

This is really nice work. See if you can combine the ghc-mod and cabal-install steps and we'll be good to merge.

jship · 2017-04-04T17:37:47Z

Was so close to completing in Travis: Travis build log.

😃

begriffs · 2017-04-04T17:46:55Z

Weird, it seems totally finished, I wonder if travis is not detecting a successful return code or something. Or maybe it's just a second or two too short...

Also do you know how to suppress this repeated message?

Warning (added by new or init): Specified resolver could not satisfy all dependencies.
Some external packages have been added as dependencies.
You can suppress this message by removing it from stack.yaml

jship · 2017-04-04T17:51:01Z

To suppress that message, we'll have to remove it from the generated stack.yaml created by stack during the dependency solving. I can sed it out of there.

jship · 2017-04-04T21:31:29Z

It was successful again but timed out based on Travis' 50-minute upper bound for jobs: https://docs.travis-ci.com/user/customizing-the-build#Build-Timeouts

The install portion took around 43 minutes according to Travis and the durations of the other phases of the job do not add up to 50 minutes. Strange.

@begriffs: Should we temporarily disable the hoogle generation and see if it passes? Maybe that way we could get the stack build artifacts cached to speed up subsequent builds.

begriffs · 2017-04-04T21:46:34Z

Temporarily disabling hoogle sounds smart, give it a try.

…d timer.

begriffs · 2017-04-05T02:44:27Z

That got it working! When you're ready, put hoogle back and we'll cross our fingers.

begriffs · 2017-04-06T13:59:58Z

Maybe the hoogle generation should be disabled when running on CI.

jship force-pushed the master branch from 8d06c91 to 7d717c2 Compare March 24, 2017 03:23

begriffs mentioned this pull request Mar 27, 2017

Plan construction failed even with 7.16 resolver #239

Closed

jship added 2 commits March 29, 2017 18:11

Use stack to solve dependencies for helper binaries.

b70d411

Hoogle 5 uses generate command instead of data command

069faa2

jship force-pushed the master branch from 7d717c2 to 069faa2 Compare March 29, 2017 23:46

jship added 2 commits March 29, 2017 21:24

Filter bogus invalid-cabal-flag-settings dependency to support older …

11fdda3

…versions of stack.

Filter bogus rts dependency to support older versions of stack.

1a676c2

begriffs reviewed Apr 4, 2017

View reviewed changes

Install ghc-mod and cabal-install with the same stack invocation.

8c62d1c

Suppress warning message from dependencies.cabal's generated stack.yaml.

6a076d6

Temporarily disable hoogle database generation to appease Travis buil…

1e3294b

…d timer.

Re-enable Hoogle database generation.

fa836a3

jship added 2 commits April 6, 2017 22:42

Add switch for disabling Hoogle database generation.

c9445bd

Disable Hoogle generation in CI.

1cf422a

begriffs merged commit 4f76d17 into begriffs:master Apr 7, 2017

jship mentioned this pull request Jun 7, 2017

Fixing install.sh so that the BASIC_ONLY option does not always skip the haskell installation. #248

Merged

Get LTS-8.5 working #238

Get LTS-8.5 working #238

Uh oh!

Conversation

jship commented Mar 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jship commented Mar 23, 2017

Uh oh!

begriffs commented Mar 23, 2017

Uh oh!

jship commented Mar 23, 2017

Uh oh!

jship commented Mar 24, 2017

Uh oh!

SX91 commented Mar 27, 2017

Uh oh!

begriffs commented Mar 27, 2017

Uh oh!

jship commented Mar 28, 2017

Uh oh!

jship commented Mar 30, 2017

Uh oh!

jship commented Mar 30, 2017

Uh oh!

jship commented Mar 30, 2017

Uh oh!

jship commented Mar 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mingyuguo commented Apr 4, 2017

Uh oh!

jiakai0419 commented Apr 4, 2017

Uh oh!

mingyuguo commented Apr 4, 2017

Uh oh!

jship commented Apr 4, 2017

Uh oh!

begriffs Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

jship Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

begriffs Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

jship Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

begriffs commented Apr 4, 2017

Uh oh!

jship commented Apr 4, 2017

Uh oh!

begriffs commented Apr 4, 2017

Uh oh!

jship commented Apr 4, 2017

Uh oh!

jship commented Apr 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

begriffs commented Apr 4, 2017

Uh oh!

begriffs commented Apr 5, 2017

Uh oh!

begriffs commented Apr 6, 2017

Uh oh!

Uh oh!

jship commented Mar 22, 2017 •

edited

Loading

jship commented Mar 30, 2017 •

edited

Loading

jship commented Apr 4, 2017 •

edited

Loading