Skip to content

support macports, package install bug fix, ensure curl #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 14, 2016

Conversation

harendra-kumar
Copy link
Contributor

This pull request has a number of fixes described below. Fixes are in logically independent commits:

  1. Support macports package manager (57d0691 & d04b877)
  2. Pass advanced install options via env vars to enable passing the options even when bash executes the script via stdin.
  3. Bug fix - bash syntax error when more than one space separated items are present in a list
  4. install script fails when curl is not installed, so install it via the package manager. I did this only for 'apt' as mac has curl by default and I cannot test for 'yum'.

+ Do not install a package if the command is found in PATH
Command line options cannot be used for direct execution of
script. Though, it is possible to do it like this:

wget -q -O- $HVN_REPO | bash /dev/stdin --basic --repo $HVN_REPO

But this does not work well (hangs) when "vim -E" is used.

We can pass the arguments via env vars instead.
@begriffs
Copy link
Owner

This looks fantastic, thank you! I'll review it in more detail tonight or tomorrow night.

@begriffs
Copy link
Owner

This works nicely. Verified that CI builds fine without a cache.

@begriffs begriffs merged commit 27e8260 into begriffs:master Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants