Better key handling for macOS and Qt#4216
Draft
corranwebster wants to merge 8 commits intobeeware:mainfrom
Draft
Better key handling for macOS and Qt#4216corranwebster wants to merge 8 commits intobeeware:mainfrom
corranwebster wants to merge 8 commits intobeeware:mainfrom
Conversation
corranwebster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, this PR minimises the use of hardware key codes for interpreting key events on macOS in favour of using the various character methods to determine the intended key press based on the keyboard layout. It doesn't yet add toga support for non-US characters, but should improve things like mapping keys correctly on an AZERTY layout keyboard.
On Qt, this PR fixes some missing key codes and fixes some issues raised by new tests.
Ref #2428.
PR Checklist: