Deprecate Python 3.8 #2888
Merged
Deprecate Python 3.8 #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
commented
Oct 7, 2024
| @@ -225,11 +225,11 @@ def __getitem__(self, path_or_index): | |||
| return self.elements[path_or_index] | |||
|
|
|||
| # Look up by path | |||
| if sys.version_info < (3, 9): # pragma: no-cover-if-gte-py39 | |||
| if sys.version_info < (3, 10): # pragma: no-cover-if-gte-py310 | |||
There was a problem hiding this comment.
This is the case that wasn't being caught by the "min + max" testing scheme. Since the problem only exists on Windows, testing 3.8 + 3.12 passed the test; 3.9 was also affected, but wasn't being checked.
mhsmith
reviewed
Oct 7, 2024
Co-authored-by: Malcolm Smith <smith@chaquo.com>
mhsmith
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is EOL at the end of this month, and #2886 highlights that we've reached the point where maintaining dependencies for 3.8 is becoming increasingly problematic.
This PR bumps the minimum Python requirement for Toga to 3.9, and removes the Python 3.8 compatibility workarounds.
As part of this change, the CI matrix for core has been modified slightly.
It turns out that we do need to run the test matrix on every version of Python - because we have conditional branches that are conditional on every version of Python on every platform. The "min and max only" testing approach was masking the fact that one of the conditional branches was using a "< 3.9" check, when it should have been a "< 3.10" check, because of a windows-specific issue.
However, we don't need to test core on both x86_64 and ARM64 macOS, as there is no logic in core that is architecture specific for macOS (or, for that matter, macOS version specific). x86_64 handling is still tested by the testbed - just not core.
Lastly, we can restore testing for Windows on Python 3.13 because a Pillow release is now available.
PR Checklist: