-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DOM storage for Android WebView #2815
Enable DOM storage for Android WebView #2815
Conversation
82da362
to
73c05cd
Compare
73c05cd
to
81fb96b
Compare
This test ended up being way more of a headache than I expected. Nonetheless, it seems to work now. I tried using I was curious how this new test compares to other "long running" tests; total runtime was 190.69s.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed the 1s delay isn't ideal, but it's not the worst sin in the testbed codebase by a large margin :-)
Looks good, and it's also good that we can confirm storage works on every other backend.
Changes
PR Checklist: