Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DOM storage for Android WebView #2815

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Sep 5, 2024

Changes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the android-enable-dom-storage branch 4 times, most recently from 82da362 to 73c05cd Compare September 5, 2024 21:27
@rmartin16
Copy link
Member Author

rmartin16 commented Sep 5, 2024

This test ended up being way more of a headache than I expected. Nonetheless, it seems to work now.

I tried using assert_content_change() to ensure it was safe to access local storage in javascript...but that wasn't always enough; just waiting a second has appeared reliable, though...

I was curious how this new test compares to other "long running" tests; total runtime was 190.69s.

I/python.stdout: 5.02s call     tests/widgets/test_mapview.py::test_zoom
I/python.stdout: 4.63s call     tests/widgets/test_detailedlist.py::test_refresh
I/python.stdout: 3.31s call     tests/widgets/test_mapview.py::test_location
I/python.stdout: 3.13s call     tests/test_fonts.py::test_font_options
I/python.stdout: 2.89s call     tests/widgets/test_mapview.py::test_add_pins
I/python.stdout: 2.22s call     tests/widgets/test_mapview.py::test_select_pin
I/python.stdout: 1.73s call     tests/widgets/test_table.py::test_font
I/python.stdout: 1.71s call     tests/widgets/test_table.py::test_column_changes
I/python.stdout: 1.29s call     tests/widgets/test_dateinput.py::test_change
I/python.stdout: 1.24s call     tests/widgets/test_table.py::test_headerless_column_changes
I/python.stdout: 1.22s setup    tests/widgets/test_mapview.py::test_focus_noop
I/python.stdout: 1.19s call     tests/widgets/test_scrollcontainer.py::test_manual_scroll
I/python.stdout: 1.16s setup    tests/widgets/test_mapview.py::test_zoom
I/python.stdout: 1.16s setup    tests/widgets/test_mapview.py::test_flex_widget_size
I/python.stdout: 1.14s call     tests/widgets/test_timeinput.py::test_change
I/python.stdout: 1.14s setup    tests/widgets/test_mapview.py::test_add_pins
I/python.stdout: 1.13s setup    tests/widgets/test_mapview.py::test_select_pin
I/python.stdout: 1.10s setup    tests/widgets/test_mapview.py::test_location
I/python.stdout: 1.06s call     tests/widgets/test_webview.py::test_dom_storage_enabled
I/python.stdout: 0.89s setup    tests/widgets/test_scrollcontainer.py::test_horizontal_scroll_small_content
I/python.stdout: 0.88s setup    tests/widgets/test_scrollcontainer.py::test_background_color
I/python.stdout: 0.88s setup    tests/widgets/test_scrollcontainer.py::test_scroll_both
I/python.stdout: 0.86s call     tests/widgets/test_canvas.py::test_transparency
I/python.stdout: 0.85s call     tests/widgets/test_canvas.py::test_multiline_text
I/python.stdout: 0.84s call     tests/widgets/test_table.py::test_cell_widget
I/python.stdout: 0.82s setup    tests/widgets/test_table.py::test_focus_noop

@rmartin16 rmartin16 marked this pull request as ready for review September 5, 2024 22:09
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed the 1s delay isn't ideal, but it's not the worst sin in the testbed codebase by a large margin :-)

Looks good, and it's also good that we can confirm storage works on every other backend.

@freakboy3742 freakboy3742 merged commit 63480d5 into beeware:main Sep 6, 2024
35 checks passed
@rmartin16 rmartin16 deleted the android-enable-dom-storage branch September 6, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable DOM storage in Android Webview
2 participants