-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add window states API #2473
Merged
Merged
Add window states API #2473
Changes from 1 commit
Commits
Show all changes
301 commits
Select commit
Hold shift + click to select a range
ab9b778
Minor modifications
proneon267 0a90a12
Minor modifications
proneon267 73721b3
Minor modifications
proneon267 c809698
Fixed bug on Window.close()
proneon267 06b7f2a
Fixed dummy backend
proneon267 11fea69
Fixed tests
proneon267 938504c
Minor cleanup
proneon267 be87113
Code Cleanup
proneon267 9aefd30
Merge branch 'window_states' of https://github.com/proneon267/toga in…
proneon267 13d2ff3
Merge branch 'beeware:main' into window_states
proneon267 176e879
Code Cleanup
proneon267 1ba73b8
Merge branch 'window_states' of https://github.com/proneon267/toga in…
proneon267 d4bfdaa
Restart CI for Linux Testbed failure
proneon267 d993b80
Merge branch 'main' into window_states
proneon267 38bf5c3
Updated to latest main branch
proneon267 b710eaf
Parameterized test on core
proneon267 b461295
Merge branch 'main' into window_states
proneon267 0c7900b
Updating to latest main branch
proneon267 97a6c66
Changed attribute to is_presentation_mode
proneon267 ba28194
Misc cleanup
proneon267 c7320ce
Name cleanups
proneon267 aed5251
Modified as per review
proneon267 a76bf9b
Added _PLATFORM_ALLOWS_CLOSE attribute on required backends
proneon267 f0d5d80
Handled deprecation warning on testbed tests
proneon267 e416f20
Removed explicit closing from dummy backend
proneon267 1fa8cde
100% coverage on core
proneon267 6350b5f
100% coverage on Android & iOS
proneon267 d091955
Restart CI for windows failure
proneon267 5c2a53b
Merge branch 'main' into window_states
proneon267 564c5ed
Updated to latest `main` branch
proneon267 e36e596
Delete changes/1857.bugfix.rst
proneon267 174d66b
Merge branch 'beeware:main' into window_states
proneon267 17564a8
Fixed testbed failures
proneon267 51cea93
Restart CI for pre-commit failure
proneon267 feb78a8
4632738
Merge branch 'window_states' of https://github.com/proneon267/toga in…
proneon267 8286b86
16d5758
Fix testbed for macOS
proneon267 5b59b14
Wayland test
proneon267 85dd202
Fix testbed for wayland
proneon267 552c0fc
Fix testbed for wayland
proneon267 56edec1
Restart CI for macOS
proneon267 971b8da
Merge branch 'main' into window_states
proneon267 934b6b1
Updated to latest main branch
proneon267 1e6bd76
Merge branch 'main' into window_states
proneon267 426e8b9
Updated to latest main branch
proneon267 ccef113
Merge branch 'beeware:main' into window_states
proneon267 4d83d19
Update changes/1857.removal.rst
proneon267 067e988
Update core/src/toga/constants/__init__.py
proneon267 3c84a80
Update core/src/toga/app.py
proneon267 a276f22
Various changes as per review: 1
proneon267 78cdd3b
Various changes as per review: 2
proneon267 b9e87c5
Various changes as per review: 3
proneon267 06d5a9e
Various changes as per review: 4
proneon267 b0c37fe
Various changes as per review: 5
proneon267 09ee428
Various changes as per review: 6
proneon267 1bd1f39
Various changes as per review: 7
proneon267 2b6d347
Added new tests as per review: 8
proneon267 8bba100
Minor change on cocoa
proneon267 6b3e883
Added tests as per review: 9
proneon267 74685d1
Restored to app presentation mode test to non-parameterized form to c…
proneon267 25c420f
Fixed testbed failures
proneon267 83dcab4
Minor change on testbed
proneon267 ab0ed45
Fixed cocoa backend and tests
proneon267 4fa4af6
Fixed dummy backend
proneon267 71f4314
Fixed gtk test backend
proneon267 a308ea7
Fixed core and added new test
proneon267 42642ee
Fixed winforms
proneon267 6b513c7
Fixed gtk backend
proneon267 ccc8f11
Fixed Android backend
proneon267 56f32a7
Test to diagnose wayland failure
proneon267 5da8231
Removed diagnostic tests
proneon267 4c6070d
Diagnostic test
proneon267 cfa255a
Various code cleanups
proneon267 87383f3
Fixed core
proneon267 c3f32c7
Minor cleanup
proneon267 4b2fdbb
Removed diagnostic tests
proneon267 b592ee2
Added review notes
proneon267 a5891e8
Fixed testbed tests
proneon267 e8ad898
100% coverage
proneon267 8684038
Removed diagnostic code
proneon267 1b53c16
diagnosing failure
proneon267 3cebc76
Revert change
proneon267 d2510e0
Merge branch 'window_states' of https://github.com/proneon267/toga in…
proneon267 4485cda
100% coverage
proneon267 d0dcb35
Merge branch 'beeware:main' into window_states
proneon267 f429307
Removed overspecified assertions and test
proneon267 6aedeea
changed is_presentation_mode to in_presentation_mode
proneon267 d7228ba
skipped some tests on the unimplemented iOS backend
proneon267 600e4c9
Modified cocoa implementation
proneon267 3689314
Typo fix on cocoa
proneon267 1a6b4ad
Merge branch 'beeware:main' into window_states
proneon267 2885d1c
Typo fix on cocoa
proneon267 cd9e00b
Typo fix on cocoa
proneon267 57fd1e3
Merge branch 'window_states' of https://github.com/proneon267/toga in…
proneon267 7835fe8
Fix cocoa
proneon267 1c0a969
Implemented new window states handling on cocoa and gtk
proneon267 cf23ce9
Fixed cocoa implementation
proneon267 e6f4dcc
Reimplemented on cocoa backend
proneon267 30e5968
Reimplemented on winforms
proneon267 c623254
f2bd750
11444e3
Reimplemented on gtk
proneon267 0771349
Update 1857.feature.rst
proneon267 c9b7b90
Removed unncessary complexity from cocoa implementation
proneon267 3441cb3
Misc fixes
proneon267 62dcd7d
Update cocoa/src/toga_cocoa/window.py
proneon267 4f36f28
ㅤ
proneon267 ea8058a
Update test_window.py
proneon267 11c3ec3
Reimplemented on cocoa backend
proneon267 0bd68c4
Reimplemented on gtk
proneon267 edef651
Merge branch 'beeware:main' into window_states
proneon267 3c8b0f1
Correcting test failure on cocoa
proneon267 e915d72
Correcting test failure on cocoa
proneon267 fb6e657
Correcting test failure on cocoa
proneon267 b810d65
Correcting test failure on cocoa
proneon267 1e59da1
Correcting test failure on cocoa
proneon267 9dba56b
Fix delegate error on cocoa
proneon267 56cc124
Fixing delegate error on cocoa
proneon267 2d29072
Add check guards for invalid impl on cocoa delegate
proneon267 c2e88e5
Removed unused state flags from gtk
proneon267 279dfda
Removed unused branch in cocoa implementation
proneon267 73bf7aa
Added checks for wayland
proneon267 af6a292
Added checks for wayland
proneon267 5a0352f
Minor gtk fix
proneon267 ef68572
Added no cover for wayland
proneon267 ca48ba2
parameterized tests on core
proneon267 cd8eba2
Reimplemented on Android
proneon267 e5eff2b
Merge branch 'main' into window_states
proneon267 26eb01c
Use the new wayland detection
proneon267 3a6aaf7
Removed legacy code from window example.
proneon267 78b5ddf
Added checks for wayland
proneon267 e0f5bf0
Minor fix on testbed
proneon267 54cfaab
Restart CI for intermittent failures
proneon267 8b8685e
Removed unused flags from Android implementation
proneon267 d599730
Merge branch 'window_states' of https://github.com/proneon267/toga in…
proneon267 91b70da
Reorganized test
proneon267 b38ff03
Merge branch 'beeware:main' into window_states
proneon267 2cf1839
Merge branch 'main' into window_states
proneon267 aa120e9
Resolving file conflicts with main branch
proneon267 3661110
Merge branch 'main' into window_states
proneon267 c928ac1
Fixed cocoa delegate
proneon267 f9c18f5
Modified testbed test
proneon267 ace13ce
Testing native OS delay for each platform
proneon267 ef7b3dc
Restart CI as previous run dropped by intermittent failure
proneon267 bc19c7f
Re-running CI to confirm cocoa errors are consistently produced
proneon267 c2235f7
Testing native OS delay for each platform
proneon267 b0ead86
Removed unused flag from gtk
proneon267 7bbf330
Restart CI for intermittent failures
proneon267 0f7fe4f
Removed unused flag on gtk
proneon267 7308e11
Enable presentation and fullscreen mode on wayland
proneon267 8f858be
Enable skipped test on wayland
proneon267 9f95554
Merge branch 'window_states' of https://github.com/proneon267/toga in…
proneon267 295cd59
Fix test timing
proneon267 5bd410e
Restart CI for intermittent failures
proneon267 00a742e
Delay tests according to native platforms
proneon267 4ef9c50
Covered missing coverage
proneon267 a1613be
Covered missing coverage
proneon267 138d0e3
Covered missing coverage
proneon267 450efad
Added XFAIL for iOS
proneon267 51d3590
Replace use of app_probe.redraw with window_probe.wait_for_window
proneon267 3de8eef
Moved presentation implementation on cocoa to window from app
proneon267 77e2b7e
Removed miniaturization delay from cocoa
proneon267 7db80d2
Removed miniaturization delay from cocoa
proneon267 aaee1f9
Ensuring coverage on macOS
proneon267 903860b
Ensuring coverage on macOS
proneon267 a6df392
Ensuring coverage on macOS
proneon267 f9f1375
Merge branch 'main' into window_states
proneon267 ad427ab
Ensuring coverage on macOS
proneon267 56de33d
Ensuring coverage on macOS
proneon267 59012cd
Ensuring coverage on macOS
proneon267 5a66725
Merge branch 'beeware:main' into window_states
proneon267 bb22a9f
Ensuring coverage on macOS
proneon267 f6a851d
Modified rapid state switching delay timing
proneon267 35bbb8e
Resolve error
proneon267 8bddf0e
Ensuring coverage on macOS
proneon267 03dd538
Update core/src/toga/window.py
proneon267 2af1509
Modified to correct expected error in test
proneon267 8b56d66
Clarified reasoning comment regarding state checks being performed at…
proneon267 7cd1489
Clarified reasoning comment regarding state checks being performed at…
proneon267 598021f
Modified testbed tests
proneon267 596acc4
Removed unused probe method from backends
proneon267 d3f90ba
Removed repeated tests
proneon267 945caf5
Removed repeated tests
proneon267 116eec3
Checking for coverage issues on macOS
proneon267 71aec38
Added no-cover on cocoa
proneon267 2559fa0
Improved tests
proneon267 d822ff0
Added platform notes
proneon267 14b64b7
Added platform notes
proneon267 d8c8422
Improved tests on mobile platform
proneon267 bb513d3
Merge branch 'beeware:main' into window_states
proneon267 eb2d9a5
Apply suggestions from code review
proneon267 abfa707
corrected pre-commit issues
proneon267 8f7c954
Moved implementation of app presentation mode to core from backends
proneon267 379e002
Removed unused code from dummy backend
proneon267 e3f31ff
corrected core tests
proneon267 383e027
Restart CI for intermittent Android failures
proneon267 c986e3d
Improved tests
proneon267 5f365c6
Improved tests
proneon267 2961507
Moved same state transition tests to core
proneon267 9ca14ed
Improved tests
proneon267 b6edc2a
Restart CI for Intermittent Android failure
proneon267 0f74ad9
Merge branch 'beeware:main' into window_states
proneon267 589e3c7
Restart CI for intermittent Android failures
proneon267 621c723
Restart CI for intermittent Android failures
proneon267 655a146
Restart CI for intermittent Android failures
proneon267 4f2f2a5
Debugging android CI failure
proneon267 c29ab39
Merge branch 'window_states' of https://github.com/proneon267/toga in…
proneon267 0d67322
Debugging android CI failure
proneon267 07e82f9
replaced with
proneon267 8be4d8d
replaced with
proneon267 1692a0d
added new method on window probe
proneon267 f8ee69d
Revert commented code
proneon267 b82b6d0
Revert
proneon267 247847e
Corrected probe method on android
proneon267 1b624ad
Merge branch 'beeware:main' into window_states
proneon267 5560e3d
Diagnosing macOS-arm64 failures
proneon267 a8fed19
Merge branch 'beeware:main' into window_states
proneon267 5f0c1a2
Correcting testbed failure
proneon267 136cdcf
Removed unused android code
proneon267 8fcdbd6
Fixed testbed for macOS
proneon267 ef584b1
Fixed testbed for Android
proneon267 7f28348
Enable additional test cases
proneon267 6e0c091
Removed stray comments
proneon267 f535cd6
Restart CI for intermittent Android failure
proneon267 c175b6a
Fix Android delay
proneon267 bc1f902
Added note on state setter
proneon267 e8864d5
Merge branch 'beeware:main' into window_states
proneon267 0f0103c
Merge branch 'beeware:main' into window_states
proneon267 4162e4b
Fixed window size after restoration to NORMAL state on wayland
proneon267 eb51730
Fixed window size setting on wayland
proneon267 b25b902
Revert changes
proneon267 8df6c4b
Add delay to prevent glitching on wayland
proneon267 1097207
Removed intermediate states from mobile test
proneon267 7e7cc1e
Merge branch 'main' into window_states
proneon267 e01237a
Correct probe property
proneon267 3236559
Separated test
proneon267 ef8725b
Simplified test cases
proneon267 9520809
Merge branch 'main' into window_states
proneon267 4ff1fd0
Pre-commit fix
proneon267 0931280
Removed unused fixture
proneon267 2024626
Modified delay indicator name
proneon267 91a8f72
Modified delay duration
proneon267 68b0a44
Removed stray comments
proneon267 0d807f6
Ignore window state requests on a hidden window
proneon267 9add077
Ignore window resize requests while in fullscreen or presentation state.
proneon267 35a49a1
Merge branch 'main' into window_states
proneon267 c7ce202
Ignore window position requests while in fullscreen or presentation s…
proneon267 23319cf
Added docstrings
proneon267 5b5e44a
Reduce test cases for rapid state assignment
proneon267 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Updating to latest main branch
- Loading branch information
commit 0c7900b721bcd7c4547cbdf40f7a45e2075ecf27
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a
:raises:
declaration for the error that will be raised.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.