Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casting str type properties + add tests (#1779) #2046

Merged
merged 9 commits into from
Jul 23, 2023
Merged

Fix casting str type properties + add tests (#1779) #2046

merged 9 commits into from
Jul 23, 2023

Conversation

tswinb
Copy link
Contributor

@tswinb tswinb commented Jul 22, 2023 •
edited by freakboy3742
Loading

  • cast multilinetextinput text fields to string
  • cast placeholder strings to string
  • add ininstance asserts for string types

Fixes #1779

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@tswinb tswinb changed the title Fixing casting str type properties + add tests (#1779) Fix casting str type properties + add tests (#1779) Jul 22, 2023
freakboy3742
freakboy3742 approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks for the contribution!

@freakboy3742 freakboy3742 merged commit 6128a34 into beeware:main Jul 23, 2023
39 checks passed
@tswinb tswinb deleted the return_strings_properties branch July 23, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cocoa MultilineTextInput.value returns an ObjCStrInstance
2 participants
@tswinb @freakboy3742