Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[widget audit] toga.Table #2011

Merged
merged 46 commits into from
Aug 28, 2023
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
88d8b29
Update docstrings and port Table tests to pytest.
freakboy3742 Jun 23, 2023
de52103
Add docs for Table.
freakboy3742 Jun 23, 2023
e6137c4
Add changenotes.
freakboy3742 Jun 23, 2023
0ddc6ab
Add deletion by index to sources, and notifications for new attribute…
freakboy3742 Jun 24, 2023
e36ca88
Cocoa Table tested for all but icons and widget cells.
freakboy3742 Jun 24, 2023
f63c715
100% coverage and testbed for icons.
freakboy3742 Jun 25, 2023
7f1d922
Run spell check before links; it's faster, and more likely to fail.
freakboy3742 Jun 25, 2023
c7dba15
iOS doesn't have a Table widget.
freakboy3742 Jun 25, 2023
a474991
Include test files in manifest.
freakboy3742 Jun 25, 2023
1e6e44d
Test fixes for py3.7 and tox.
freakboy3742 Jun 25, 2023
3be907c
Cocoa Table to 100% coverage.
freakboy3742 Jun 26, 2023
399baf3
Correct row position calculation.
freakboy3742 Jun 26, 2023
564ab0f
Simplify activation handler.
freakboy3742 Jun 26, 2023
8e9e521
Update examples to reflect changes to table.
freakboy3742 Jun 26, 2023
cf121f4
Fix Windows failure
mhsmith Jun 26, 2023
bf7404a
Make Selection consistently unfocusable on Android
mhsmith Jun 26, 2023
e8c8983
Add explicit warnings for handler name change.
freakboy3742 Jun 26, 2023
dd70006
Add an explicit note that ListSource is list-like.
freakboy3742 Jun 26, 2023
81a4f25
Remove a platform test that is no longer needed.
freakboy3742 Jun 27, 2023
358cdc1
Switch GTK to use GdkPixBuf as the native Icon widget, and require a …
freakboy3742 Jun 27, 2023
0e4c2ad
Make the pause after a keystroke a default behavior.
freakboy3742 Jun 27, 2023
e05b675
GTK Table widget to 100%.
freakboy3742 Jun 27, 2023
77a7e4d
Add documentation notes about icons and widgets in Table.
freakboy3742 Jun 27, 2023
0e09760
Mark Android as 'done'; the implementation isn't complete enough for …
freakboy3742 Jun 27, 2023
8c57ecf
Add test that columns fill the available space.
freakboy3742 Jun 27, 2023
903fb17
Increase the allowance for inter-column padding.
freakboy3742 Jun 28, 2023
80b9853
Small cleanups of core API tests.
freakboy3742 Jun 29, 2023
210402d
Add keyboard shortcuts for select-all on Cocoa (copied from Tree)
freakboy3742 Jun 29, 2023
c92f36a
Add error handling for bad icon files.
freakboy3742 Jul 8, 2023
347abf9
Merge branch 'main' into audit-table
freakboy3742 Jul 17, 2023
fef0258
Merge branch 'main' into audit-table
freakboy3742 Jul 26, 2023
e0124c7
Merge branch 'main' into audit-table
freakboy3742 Jul 26, 2023
b23d4d5
Merge branch 'main' into audit-table
freakboy3742 Aug 4, 2023
ec1ac83
Merge branch 'main' into audit-table
mhsmith Aug 22, 2023
1e8deea
Documentation cleanups
mhsmith Aug 22, 2023
0c17678
Icon documentation cleanups
mhsmith Aug 22, 2023
b76e453
Apply suggestions from code review
mhsmith Aug 23, 2023
7c67ded
Avoid wrapping in examples
mhsmith Aug 23, 2023
ef88f58
More docs clarifications
mhsmith Aug 23, 2023
673b061
Merge branch 'main' into audit-table
mhsmith Aug 23, 2023
3d3641c
Winforms Table to 100% coverage
mhsmith Aug 24, 2023
37540d1
Winforms Icon to 100% coverage
mhsmith Aug 24, 2023
284b13f
Don't require final scroll position to be equal to starting position
mhsmith Aug 24, 2023
6e116c9
Android Table to 100% coverage
mhsmith Aug 27, 2023
1784000
Android Icon to 100% coverage
mhsmith Aug 27, 2023
b6c0d04
Add tests for accessors returning None, and fix on Cocoa and Winforms
mhsmith Aug 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into audit-table
  • Loading branch information
freakboy3742 committed Jul 17, 2023
commit 347abf9bfed09a0a3f02c5f59e494b9b3de50daa
12 changes: 0 additions & 12 deletions core/tests/test_deprecated_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,6 @@ def test_option_container_created(self):
self.assertEqual(widget._impl.interface, widget)
self.assertNotEqual(widget.factory, self.factory)

def test_scroll_container_created(self):
with self.assertWarns(DeprecationWarning):
widget = toga.ScrollContainer(factory=self.factory)
self.assertEqual(widget._impl.interface, widget)
self.assertNotEqual(widget.factory, self.factory)

def test_split_container_created(self):
with self.assertWarns(DeprecationWarning):
widget = toga.SplitContainer(factory=self.factory)
self.assertEqual(widget._impl.interface, widget)
self.assertNotEqual(widget.factory, self.factory)

def test_tree_created(self):
with self.assertWarns(DeprecationWarning):
widget = toga.Tree(headings=["Test"], factory=self.factory)
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.