-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gtk4 migration #1978
Draft
MuhammadMuradG
wants to merge
131
commits into
beeware:main
Choose a base branch
from
MuhammadMuradG:gtk4-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Gtk4 migration #1978
Changes from 1 commit
Commits
Show all changes
131 commits
Select commit
Hold shift + click to select a range
37c0546
Setup the the baiscs of migration
ac3ae7e
[detailedlist] migrate detailedlist and its dependencies
4ec985b
[label] migratet label widget
18b87f8
[divider] migrate divider widget
10dfb76
[imageview] migrate imageview widget
839bd45
[basics] fix the style implementation
ac75996
[multilinetextinput] migrate the multilinetextiput widget
5c6c92f
[basics] fix the style implementation
bd24cbf
[error] remove unintended commits
9e5d27c
[numberinput] migrate the numberinput widget
1f91dde
[textinput] migrate the textinput widget
10e5162
[textinput] migrate the textinput widget
6b06b72
[progressbar] migrate the progressbar widget
5141fe3
[scrollcontainer] migrate the scrollcontainer widget
19c564f
[detailedlist] fix minimum width
afde981
[selection] migrate the selection widget
680f738
[slider] migrate slider widget
eb7db21
[detailedlist] some widget access attributes cleaning
b40c338
[activityindicator] migrate activityindicator widget
1d3a74e
[splitcontainer] migrate splitcontainer widget
ede61d6
[switch] migrate switch widget
3cdce3e
[slider] some tweak cleaning
471087d
[selection] some tweak cleaning
82c9c29
[detailedlist] some tweak cleaning
e9334ff
[scrollcontainer] fix unmigrated method
9579bc9
[optioncontainer] fix unmigrated details
742aa86
[pre-commit] Fix flake3 formating
58b6a08
[towncrier] add changenete
9d3646b
[pre-commit] Fix import sorting using isort
2e050db
[pre-commit] Fix black formating
7886861
[basics] Fix backward compitability of different gtkr versions in app…
b6d928e
Merge branch 'main' into gtk4-migration
MuhammadMuradG ba8206b
[pre-commit] Fix black formating
c546dd4
[selection] Fix item insertion
fb412dc
[selection] Remove search bar
651c401
Update ci.yml
MuhammadMuradG f5a23af
Update ci.yml
MuhammadMuradG a7743d8
[CI] Add Gtk4 system package
MuhammadMuradG cac5a34
[GTK backend] Fix texts
28de4e3
[testbed] Fix display retrieving
7810109
Update ci.yml
MuhammadMuradG 5d4ca07
Update ci.yml
MuhammadMuradG 7f12030
[CI] Add Gtk4 system package
MuhammadMuradG bc54771
Merge branch 'gtk4-migration' of https://github.com/MuhammadMouradG/t…
0797051
[backend test] Fix setting window child
a4d60a9
[selection] Fix styles
dd4fcb8
[docstring] Keep docstring consistency through project
963bd4d
[selection] Fix reduce minimum size
f575dd3
[testbed] Remove 'shrink_on_rsize' property from selection test
fba26cf
[testbed] Fix backend redrawing request
69e4234
Resolve conflicts in splitcontatiner
80dc33a
Merge branch 'main' into gtk4-migration
MuhammadMuradG f85b545
[docstring] Keep docstring consistency through project
ea7f98f
Fix the resolved conflicts in container
e9305c2
Resolve merging conflicts.
MuhammadMuradG 4c3083e
Fix resolved merged confilicts.
MuhammadMuradG 09983db
Fix unresolved CI confilicts.
MuhammadMuradG 19f0bad
Fix flake8 formating
MuhammadMuradG c7b7b2b
[Basics] Fix toga container Layout and widgets visiblity.
MuhammadMuradG 88c6ec1
[testbed] Passing base testbed.
MuhammadMuradG 9ad1a70
[Cleanup] Some comments and docstring enhancing.
MuhammadMuradG a9e4e9a
[testbed] Await time fraction on next iter of the main loop; This is …
MuhammadMuradG e8dd20f
[basics] Resolve merging conflicts.
MuhammadMuradG 2450f9b
[testbed] Fix box properties tests.
MuhammadMuradG 94323db
[Cleanup] Fix flake8 formating.
MuhammadMuradG cc6dfab
[testbed] Fix redrawing conditions with some performance.
MuhammadMuradG 35b3e25
Merge branch 'beeware:main' into gtk4-migration
MuhammadMuradG 2d26ac3
[Selection] Replace the using of deprecated method.
MuhammadMuradG 69731a4
[Selection] Fix widget size after change the selected item.
MuhammadMuradG 04ad8b1
[Testbed] Doesn't wait for resources on each iteration.
MuhammadMuradG 028693e
[Widget] Fix focus checking.
MuhammadMuradG 80f45cf
[Testbed] Fix box focus tests.
MuhammadMuradG 50d32a6
Merge branch 'beeware:main' into gtk4-migration
MuhammadMuradG 6062d99
[Testbed] Fix background color reset test.
MuhammadMuradG 0dc1a3f
[Testbed] Handling edge cases in layout tests.
MuhammadMuradG 6b7d7a1
[Testbed] Fix content size and fullscreen tests.
MuhammadMuradG a8356b5
[Window] Some code cleaning.
MuhammadMuradG 21cdc50
[Widget] Fix focus checking.
MuhammadMuradG 6be6f95
[Testbed] Fix widget focus test.
MuhammadMuradG b5bc802
[Testbed] Fix app tests.
MuhammadMuradG 4b92256
Resolve merging conflicts.
MuhammadMuradG 18227a8
Merge branch 'beeware:main' into gtk4-migration
MuhammadMuradG e4c59d9
[Testbed] Fix font attributes tests.
MuhammadMuradG 9480052
[Testbed] Fix font attributes edge cases tests.
MuhammadMuradG 4d53250
[Testbed] Fix icons tests.
MuhammadMuradG d44de50
Resolve merging conflicts.
MuhammadMuradG 93442ca
[Testbed] Fix platform path icons tests.
MuhammadMuradG fdeb37e
[Cleanup] Fix black formating.
MuhammadMuradG 9af8cc3
Merge branch 'beeware:main' into gtk4-migration
MuhammadMuradG 99fdb3b
[Testbed] Fix window position tests.
MuhammadMuradG 02dcef5
[Docs] Update notes on window positioning.
MuhammadMuradG e191ebe
[Docs] Fix typos.
MuhammadMuradG 4820df8
[Cleanup] Fix docs formating.
MuhammadMuradG a7d8ec1
[Testbed] Fix unintended changes window configs.
MuhammadMuradG 15bbf29
[Docs] Fix word spilling typo.
MuhammadMuradG 375af80
[Docs] Add positioning to spelling wordlist.
MuhammadMuradG d86a10a
[Docs] Fix the positioning note in window doc.
MuhammadMuradG a57d881
[Testbed] Fix key tests.
MuhammadMuradG 6a75cb7
Merge branch 'beeware:main' into gtk4-migration
MuhammadMuradG ffc792b
[Testbed] Fix unintended commit in window config test.
MuhammadMuradG b27e095
[Dialogs] Migrate dialogs.
MuhammadMuradG d7e472c
[Testbed] Fix message dialog tests.
MuhammadMuradG c5d8c1f
[Dialog] Migrate and fix file dialogs.
MuhammadMuradG 712b12e
[Testbed] Fix file dialog tests.
MuhammadMuradG 47646e9
[Widget] Fix memory leaks on window ref.
MuhammadMuradG d319479
[Cleanup] Fix black formating.
MuhammadMuradG 4ca83be
Merge branch 'beeware:main' into gtk4-migration
MuhammadMuradG 9310555
[Cleanup] Imports cleanup.
MuhammadMuradG d0d7d7c
[Testbed] Fix window positioning and screenshot tests.
MuhammadMuradG 952b002
Merge branch 'beeware:main' into gtk4-migration
MuhammadMuradG 3fcd351
[Testbed] Passing window image test.
MuhammadMuradG 13f2982
[Testbed] Fix window image test.
MuhammadMuradG a90541d
[Cleanup] Some comments cleaning.
MuhammadMuradG b4f31ca
Resolve merging conflicts.
MuhammadMuradG 62ae5e0
[Coverage] Fix window caverage tests.
MuhammadMuradG 2d6e631
[Base] Fix widget size on css changing.
MuhammadMuradG de38ac4
[Icons] Migrating the used extensible icon sizes.
MuhammadMuradG 7ccd780
[Testbed] Fix icons tests.
MuhammadMuradG 7fd4872
[Button] Fix button icon tests.
MuhammadMuradG 6041617
[Button] Fix button text tests.
MuhammadMuradG 330d45f
[Button] Passing button tests.
MuhammadMuradG bafd283
Merge branch 'main' into gtk4-migration
MuhammadMuradG 8a289c4
[Cleanup] Fix black formating.
MuhammadMuradG 8e78c4e
[Cleanup] Fix black formating.
MuhammadMuradG fb1c27d
[Button] Complete passing button tests.
MuhammadMuradG ea6f986
[Docs] Update icon implementation docs.
MuhammadMuradG 0bf0e25
[Cleanup] Fix docs formating.
MuhammadMuradG 06b9a8f
Merge branch 'beeware:main' into gtk4-migration
MuhammadMuradG 0eff81a
[imageview] Fix backend implementation.
MuhammadMuradG 874f99f
[Testbed] Passing imageview tests.
MuhammadMuradG 96554f1
[Cleanup] Add native widget str representation and add some comments.
MuhammadMuradG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Cleanup] Fix black formating.
- Loading branch information
commit fdeb37eddee281f0aa9bb6275c8656a7fcaa9aee
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be required. The testbed backend is, by definition, platform specific. There isn't a separate FreeBSD backend, so there's no need for configurability at this level.
At best, there's a need for the GTK backend to differentiate between Linux and FreeBSD icons - but that can be entirely contained in the GTK test backend.
Even then, I'm not 100% convinced that's the right approach. The icons are going to be interpreted by GTK, not BSD; it's arguable whether the icons for linux should be suffixed "-gtk" rather than "-linux", specifically because of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this was what I asked to myself when I did what I did.
In fact, I'm convinced with the "-gtk" suffix rather than "-linux", especially because we can use "gtk" on "windows" and "macOS", but my priority currently is passing the tests and keep the original behavior to other platforms as it is, with minimizing the changes in other backends and layers. Is this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say a potential conflict with Qt is much more likely than "GTK on Windows/macOS".
I could even see an argument for supporting both suffixes -
-<platform>
and-gtk
- on the basis that you might want freeBSD-specific icons on the GTK backend to match FreeBSD desktop style (I don't know if that's a thing that is likely in practice, but it seems plausible).However, as you note, this is probably best handled as a separate discussion/PR.