GTK DetailedList bug fix #1924
Closed
GTK DetailedList bug fix #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o get it to set min_size based on contents.
freakboy3742
requested changes
May 3, 2023
There was a problem hiding this comment.
Nice debug work - but the solution is actually even simpler than this. The GTK implementation of DetailedList is missing a rehint() method, so it's never telling the core layout algorithm that it's able to resize to fill the container.
I've implemented this in #1927, so I'll close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed how the scrolled_window was added to the overlay. Also changed the set_policy for scrolled_window to allow for horizontal scroll to update width of the detailedlist.
Added _update_scrolled_window_width which will loop through all of the list_box children and update the width of what I assume is the scrolled window but may actually be the overlay, not fully sure. Name may need to be adjusted.
When a detailedlist is added to a box, it currently does not show at all. This shows the detailed list inside the box at the min_width.
Fixes #1920
PR Checklist: