Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[widget audit] toga.Button #1761

Merged
merged 66 commits into from
Mar 21, 2023
Merged

[widget audit] toga.Button #1761

merged 66 commits into from
Mar 21, 2023

Commits on Feb 25, 2023

  1. Whitespace change to use as the starting point for a PR.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    92fd082 View commit details
    Browse the repository at this point in the history

  2. Add changenote.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    d206715 View commit details
    Browse the repository at this point in the history

  3. Fix tracing on Windows

    @mhsmith @freakboy3742
    mhsmith authored and freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    9fdf46e View commit details
    Browse the repository at this point in the history

  4. Migrate dummy widget tools to pytest.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    38bd4d6 View commit details
    Browse the repository at this point in the history

  5. Remove use of shadow attribute for button label.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    b541c09 View commit details
    Browse the repository at this point in the history

  6. Convert Button tests to pytest.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    7077562 View commit details
    Browse the repository at this point in the history

  7. Fix Android tests, get to 100% coverage.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    ec04ddc View commit details
    Browse the repository at this point in the history

  8. Fix get_text implementation on gtk and winforms.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    859ad48 View commit details
    Browse the repository at this point in the history

  9. 100% coverage on iOS.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f93158e View commit details
    Browse the repository at this point in the history

  10. Remove deprecated code from Button.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    67f3374 View commit details
    Browse the repository at this point in the history

  11. Winforms to 100%.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    ca8a760 View commit details
    Browse the repository at this point in the history

  12. GTK to 100%.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    8a03783 View commit details
    Browse the repository at this point in the history

  13. Winforms to 100%, no skips.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    37985ae View commit details
    Browse the repository at this point in the history

  14. Add test selection from the command line, and a slow mode.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    2b9714e View commit details
    Browse the repository at this point in the history

  15. Fix and mark tests that aren't reliable

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    2ea497e View commit details
    Browse the repository at this point in the history

  16. Updated dummy assertions to be simple functions.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    c8e41b1 View commit details
    Browse the repository at this point in the history

  17. GTK Button color tests passing.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    a07ebde View commit details
    Browse the repository at this point in the history

  18. Add a warning about UI animations.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    e6c3096 View commit details
    Browse the repository at this point in the history

  19. Re-enable the button size test.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    163fa97 View commit details
    Browse the repository at this point in the history

  20. Correct handling of color for non-button widgets.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    8c24cbe View commit details
    Browse the repository at this point in the history

  21. Remove refresh calls that aren't needed any more.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    df7c13e View commit details
    Browse the repository at this point in the history

  22. Removed the xfail marker from some tests.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    d1fdf8b View commit details
    Browse the repository at this point in the history

  23. Modified the color test to assert all components in one assertion.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    2e7f8d0 View commit details
    Browse the repository at this point in the history

  24. Use a programmatic approach to disable animations.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    da9c1ba View commit details
    Browse the repository at this point in the history

  25. iOS Button tests to 100%.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    50c4fee View commit details
    Browse the repository at this point in the history

  26. iOS button to 100%.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    4a2944f View commit details
    Browse the repository at this point in the history

  27. Partial fixes for Android colors and fonts.

    @freakboy3742
    freakboy3742 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    fe92bb9 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Implement await redraw for Android

    @mhsmith
    mhsmith committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    73f0c5a View commit details
    Browse the repository at this point in the history

  2. Fix Android font size calculation

    @mhsmith
    mhsmith committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    2ff0e95 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Fix button background color

    @mhsmith
    mhsmith committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    e6ed1c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Modify font size and font handling.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    db63ecc View commit details
    Browse the repository at this point in the history

  2. Add support for resetting foreground color.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    493e722 View commit details
    Browse the repository at this point in the history

  3. Ensure size probes return SP not DP.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    c3d5c8a View commit details
    Browse the repository at this point in the history

  4. Use del rather than assigning None to clear style.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    542faf7 View commit details
    Browse the repository at this point in the history

  5. Don't allow newlines in button text.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    d3581ec View commit details
    Browse the repository at this point in the history

  6. Correct label color tests.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    e1458ba View commit details
    Browse the repository at this point in the history

  7. Button at 100% on all tested platforms!

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    32451bd View commit details
    Browse the repository at this point in the history

  8. Rework the EventLog so it is global.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    c788a8c View commit details
    Browse the repository at this point in the history

  9. Disallow empty labels on buttons.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    da5105a View commit details
    Browse the repository at this point in the history

  10. Revert a libs restructure.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    5bf1cbb View commit details
    Browse the repository at this point in the history

  11. More tweaks to the dummy test assertions.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    29924f0 View commit details
    Browse the repository at this point in the history

  12. Removed a redundant background color implementation.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    7e2bc2d View commit details
    Browse the repository at this point in the history

  13. Add notes about button text restrictions.

    @freakboy3742
    freakboy3742 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    8211f8b View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge branch 'main' into audit-button

    @freakboy3742
    freakboy3742 committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    8cd8531 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Change = None tests to del, for compatibility with travertino mai… 

    …n branch
    @mhsmith
    mhsmith committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    857d899 View commit details
    Browse the repository at this point in the history

  2. Fix Android font size, and add font size reset test

    @mhsmith
    mhsmith committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    7bd87a5 View commit details
    Browse the repository at this point in the history

  3. Add memory retention for cached font instances.

    @freakboy3742
    freakboy3742 committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    16ec542 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Merge branch 'system-ci' into audit-button

    @mhsmith
    mhsmith committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    8bd9528 View commit details
    Browse the repository at this point in the history

  2. Allow default font to be returned as SANS_SERIF as well as SYSTEM

    @mhsmith
    mhsmith committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e83f2fa View commit details
    Browse the repository at this point in the history

  3. Add examples/font_size

    @mhsmith
    mhsmith committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    81e2d29 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Add bold and italic font tests (working on Android, Cocoa and iOS)

    @mhsmith
    mhsmith committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    02a345d View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Add bold and italic font tests (working on GTK and Winforms)

    @mhsmith
    mhsmith committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    9248973 View commit details
    Browse the repository at this point in the history

  2. Remove redundant set_font methods in dummy widgets

    @mhsmith
    mhsmith committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    45e52e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Merge branch 'main' into audit-button

    @freakboy3742
    freakboy3742 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    8445dae View commit details
    Browse the repository at this point in the history

  2. Improve comments

    @mhsmith
    mhsmith committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c646ef0 View commit details
    Browse the repository at this point in the history

  3. Move generic font mapping assertions to tests_backend (Android, Cocoa… 

    …, iOS)
    @mhsmith
    mhsmith committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e2da16b View commit details
    Browse the repository at this point in the history

  4. Move generic font mapping assertions to tests_backend (GTK)

    @mhsmith
    mhsmith committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    926c3d6 View commit details
    Browse the repository at this point in the history

  5. Move generic font mapping assertions to tests_backend (Winforms)

    @mhsmith
    mhsmith committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7f96efa View commit details
    Browse the repository at this point in the history

  6. Fix typos

    @mhsmith
    mhsmith authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    36ed554 View commit details
    Browse the repository at this point in the history

  7. Allow Button text to be set to an empty string, and make Winforms dis… 

    …play a single space to prevent the widget from collapsing
    @mhsmith
    mhsmith committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    091e3ec View commit details
    Browse the repository at this point in the history

  8. Use subclassing rather than an isinstance check.

    @freakboy3742
    freakboy3742 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    dd73a9b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Revert the use of an interface state variable for button text.

    @freakboy3742
    freakboy3742 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    cfdc3e5 View commit details
    Browse the repository at this point in the history

  2. Mark some classes with Test in the name as not-tests.

    @freakboy3742
    freakboy3742 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ce54201 View commit details
    Browse the repository at this point in the history

  3. Tweak section heading.

    @freakboy3742
    freakboy3742 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5abe2f1 View commit details
    Browse the repository at this point in the history

  4. Modify the winforms button probe to do ZWS normalization.

    @freakboy3742
    freakboy3742 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f76c90a View commit details
    Browse the repository at this point in the history

  5. Use correct zero width space character, and remove unnecessary workar… 

    …ound in testbed
    @mhsmith
    mhsmith committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8f55716 View commit details
    Browse the repository at this point in the history