Removed the xfail marker from some tests.

beeware · Feb 16, 2023 · 4a1ce8a · 4a1ce8a
1 parent 3a978ba
commit 4a1ce8a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/core/tests/widgets/test_optioncontainer.py b/core/tests/widgets/test_optioncontainer.py
@@ -1,4 +1,4 @@
-from unittest import expectedFailure, mock
+from unittest import mock
 
 import toga
 from toga_dummy.utils import TestCase, TestStyle
@@ -36,15 +36,11 @@ def test_widget_created(self):
         self.assertEqual(self.op_container._impl.interface, self.op_container)
         self.assertActionPerformed(self.op_container, "create OptionContainer")
 
-    # This isn't a good test as it asserts behavior performed during setUp
-    @expectedFailure
     def test_adding_container_invokes_add_content(self):
         self.assertActionPerformedWith(
             self.op_container, "add content", text=self.text, widget=self.widget._impl
         )
 
-    # This isn't a good test as it asserts behavior performed during setUp
-    @expectedFailure
     def test_widget_refresh_sublayouts(self):
         # Clear event log to verify new set bounds for refresh
         self.reset_event_log()

diff --git a/core/tests/widgets/test_scrollcontainer.py b/core/tests/widgets/test_scrollcontainer.py
@@ -1,4 +1,4 @@
-from unittest import expectedFailure, mock
+from unittest import mock
 
 import toga
 from toga_dummy.utils import TestCase, TestStyle
@@ -37,8 +37,6 @@ def test_set_vertical_scroll_position(self):
         self.assertEqual(self.sc.horizontal_position, 0)
         self.assertEqual(self.sc.vertical_position, vertical_position)
 
-    # This isn't a good test as it asserts behavior performed during setUp
-    @expectedFailure
     def test_set_content_with_widget(self):
         self.assertEqual(
             self.sc.content, None, "The default value of content should be None"

diff --git a/core/tests/widgets/test_splitcontainer.py b/core/tests/widgets/test_splitcontainer.py
@@ -1,4 +1,4 @@
-from unittest import expectedFailure, mock
+from unittest import mock
 
 import toga
 from toga_dummy.utils import TestCase, TestStyle
@@ -26,8 +26,6 @@ def test_setting_content_false_input(self):
         with self.assertRaises(ValueError):
             self.split.content = [toga.Box()]
 
-    # This isn't a good test as it asserts behavior performed during setUp
-    @expectedFailure
     def test_setting_content_invokes_impl_method(self):
         new_content = [toga.Box(style=TestStyle()), toga.Box(style=TestStyle())]
         self.split.content = new_content